[libcamera-devel,v4,02/11] libcamera: controls: Add AeEnable control

Message ID 20191003174941.1296988-3-niklas.soderlund@ragnatech.se
State Superseded
Headers show
Series
  • libcamera: ipa: Add basic IPA support
Related show

Commit Message

Niklas Söderlund Oct. 3, 2019, 5:49 p.m. UTC
Add a control to enable/disable Auto Exposure.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/control_ids.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Laurent Pinchart Oct. 3, 2019, 9:47 p.m. UTC | #1
Hi Niklas,

Thank you for the patch.

On Thu, Oct 03, 2019 at 07:49:32PM +0200, Niklas Söderlund wrote:
> Add a control to enable/disable Auto Exposure.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
>  src/libcamera/control_ids.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 819a5967a2fc8d56..4626f6ef48bcaeea 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -5,6 +5,13 @@
>  %YAML 1.2
>  ---
>  controls:
> +  - AeEnable:
> +      type: bool
> +      description: |
> +        Enables or disables the AE.

s/Enables or disables/Enable or disable/

(AwbEnable should be fixed accordingly)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +
> +        \sa ManualExposure
> +
>    - AwbEnable:
>        type: bool
>        description: |

Patch

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 819a5967a2fc8d56..4626f6ef48bcaeea 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -5,6 +5,13 @@ 
 %YAML 1.2
 ---
 controls:
+  - AeEnable:
+      type: bool
+      description: |
+        Enables or disables the AE.
+
+        \sa ManualExposure
+
   - AwbEnable:
       type: bool
       description: |