[libcamera-devel,2/5] test: ipa: Rename the ipa_test to ipa_module_test

Message ID 20191003152037.74617-3-jacopo@jmondi.org
State Superseded
Headers show
Series
  • test: Add IPA interface test support
Related show

Commit Message

Jacopo Mondi Oct. 3, 2019, 3:20 p.m. UTC
Update the IPA test to match the test class name in prevision of adding
more IPA tests. Also update the description comment in the test unit, as
the old name for the test was still used.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 test/ipa/{ipa_test.cpp => ipa_module_test.cpp} | 2 +-
 test/ipa/meson.build                           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (95%)

Comments

Laurent Pinchart Oct. 3, 2019, 4:18 p.m. UTC | #1
Hi Jacopo,

Thank you for the patch.

On Thu, Oct 03, 2019 at 05:20:34PM +0200, Jacopo Mondi wrote:
> Update the IPA test to match the test class name in prevision of adding
> more IPA tests. Also update the description comment in the test unit, as
> the old name for the test was still used.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  test/ipa/{ipa_test.cpp => ipa_module_test.cpp} | 2 +-
>  test/ipa/meson.build                           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (95%)
> 
> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_module_test.cpp
> similarity index 95%
> rename from test/ipa/ipa_test.cpp
> rename to test/ipa/ipa_module_test.cpp
> index 8f9b2d8058ec..3a634099a550 100644
> --- a/test/ipa/ipa_test.cpp
> +++ b/test/ipa/ipa_module_test.cpp
> @@ -2,7 +2,7 @@
>  /*
>   * Copyright (C) 2019, Google Inc.
>   *
> - * load-so.cpp - loading .so tests
> + * ipa_module_test.cpp - Test loading of the VIMC IPA module and verify its info
>   */
>  
>  #include <iostream>
> diff --git a/test/ipa/meson.build b/test/ipa/meson.build
> index 1749ab7d4338..e174671d05e1 100644
> --- a/test/ipa/meson.build
> +++ b/test/ipa/meson.build
> @@ -1,5 +1,5 @@
>  ipa_test = [
> -    ['ipa_test', 'ipa_test.cpp'],
> +    ['ipa_module_test', 'ipa_module_test.cpp'],
>  ]
>  
>  foreach t : ipa_test
Niklas Söderlund Oct. 3, 2019, 8:28 p.m. UTC | #2
Hi Jacopo,

Thanks for your work.

On 2019-10-03 17:20:34 +0200, Jacopo Mondi wrote:
> Update the IPA test to match the test class name in prevision of adding
> more IPA tests. Also update the description comment in the test unit, as
> the old name for the test was still used.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  test/ipa/{ipa_test.cpp => ipa_module_test.cpp} | 2 +-
>  test/ipa/meson.build                           | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>  rename test/ipa/{ipa_test.cpp => ipa_module_test.cpp} (95%)
> 
> diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_module_test.cpp
> similarity index 95%
> rename from test/ipa/ipa_test.cpp
> rename to test/ipa/ipa_module_test.cpp
> index 8f9b2d8058ec..3a634099a550 100644
> --- a/test/ipa/ipa_test.cpp
> +++ b/test/ipa/ipa_module_test.cpp
> @@ -2,7 +2,7 @@
>  /*
>   * Copyright (C) 2019, Google Inc.
>   *
> - * load-so.cpp - loading .so tests
> + * ipa_module_test.cpp - Test loading of the VIMC IPA module and verify its info
>   */
>  
>  #include <iostream>
> diff --git a/test/ipa/meson.build b/test/ipa/meson.build
> index 1749ab7d4338..e174671d05e1 100644
> --- a/test/ipa/meson.build
> +++ b/test/ipa/meson.build
> @@ -1,5 +1,5 @@
>  ipa_test = [
> -    ['ipa_test', 'ipa_test.cpp'],
> +    ['ipa_module_test', 'ipa_module_test.cpp'],
>  ]
>  
>  foreach t : ipa_test
> -- 
> 2.23.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/test/ipa/ipa_test.cpp b/test/ipa/ipa_module_test.cpp
similarity index 95%
rename from test/ipa/ipa_test.cpp
rename to test/ipa/ipa_module_test.cpp
index 8f9b2d8058ec..3a634099a550 100644
--- a/test/ipa/ipa_test.cpp
+++ b/test/ipa/ipa_module_test.cpp
@@ -2,7 +2,7 @@ 
 /*
  * Copyright (C) 2019, Google Inc.
  *
- * load-so.cpp - loading .so tests
+ * ipa_module_test.cpp - Test loading of the VIMC IPA module and verify its info
  */
 
 #include <iostream>
diff --git a/test/ipa/meson.build b/test/ipa/meson.build
index 1749ab7d4338..e174671d05e1 100644
--- a/test/ipa/meson.build
+++ b/test/ipa/meson.build
@@ -1,5 +1,5 @@ 
 ipa_test = [
-    ['ipa_test', 'ipa_test.cpp'],
+    ['ipa_module_test', 'ipa_module_test.cpp'],
 ]
 
 foreach t : ipa_test