| Message ID | 20240805100038.11972-4-jaslo@ziska.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Thanks. Le lundi 05 août 2024 à 11:28 +0200, Jaslo Ziska a écrit : > Signed-off-by: Jaslo Ziska <jaslo@ziska.de> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > --- > src/gstreamer/gstlibcamerasrc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index 85dab67f..1a277fcc 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -941,7 +941,7 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass) > gst_element_class_set_metadata(element_class, > "libcamera Source", "Source/Video", > "Linux Camera source using libcamera", > - "Nicolas Dufresne <nicolas.dufresne@collabora.com"); > + "Nicolas Dufresne <nicolas.dufresne@collabora.com>"); > gst_element_class_add_static_pad_template_with_gtype(element_class, > &src_template, > GST_TYPE_LIBCAMERA_PAD);
Quoting Jaslo Ziska (2024-08-05 10:28:38) > Signed-off-by: Jaslo Ziska <jaslo@ziska.de> Perhaps this one could/should get picked up already, separately from the rest of the series so we don't carry it around. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/gstreamer/gstlibcamerasrc.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > index 85dab67f..1a277fcc 100644 > --- a/src/gstreamer/gstlibcamerasrc.cpp > +++ b/src/gstreamer/gstlibcamerasrc.cpp > @@ -941,7 +941,7 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass) > gst_element_class_set_metadata(element_class, > "libcamera Source", "Source/Video", > "Linux Camera source using libcamera", > - "Nicolas Dufresne <nicolas.dufresne@collabora.com"); > + "Nicolas Dufresne <nicolas.dufresne@collabora.com>"); > gst_element_class_add_static_pad_template_with_gtype(element_class, > &src_template, > GST_TYPE_LIBCAMERA_PAD); > -- > 2.46.0 >
On Wed, Aug 07, 2024 at 08:51:58AM +0100, Kieran Bingham wrote: > Quoting Jaslo Ziska (2024-08-05 10:28:38) > > Signed-off-by: Jaslo Ziska <jaslo@ziska.de> > > Perhaps this one could/should get picked up already, separately from the > rest of the series so we don't carry it around. Done. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > src/gstreamer/gstlibcamerasrc.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp > > index 85dab67f..1a277fcc 100644 > > --- a/src/gstreamer/gstlibcamerasrc.cpp > > +++ b/src/gstreamer/gstlibcamerasrc.cpp > > @@ -941,7 +941,7 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass) > > gst_element_class_set_metadata(element_class, > > "libcamera Source", "Source/Video", > > "Linux Camera source using libcamera", > > - "Nicolas Dufresne <nicolas.dufresne@collabora.com"); > > + "Nicolas Dufresne <nicolas.dufresne@collabora.com>"); > > gst_element_class_add_static_pad_template_with_gtype(element_class, > > &src_template, > > GST_TYPE_LIBCAMERA_PAD);
diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 85dab67f..1a277fcc 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -941,7 +941,7 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass) gst_element_class_set_metadata(element_class, "libcamera Source", "Source/Video", "Linux Camera source using libcamera", - "Nicolas Dufresne <nicolas.dufresne@collabora.com"); + "Nicolas Dufresne <nicolas.dufresne@collabora.com>"); gst_element_class_add_static_pad_template_with_gtype(element_class, &src_template, GST_TYPE_LIBCAMERA_PAD);
Signed-off-by: Jaslo Ziska <jaslo@ziska.de> --- src/gstreamer/gstlibcamerasrc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)