| Message ID | 20240804205544.2500138-1-slyich@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Sergei, Thank you for the patch. On Sun, Aug 04, 2024 at 09:55:43PM +0100, Sergei Trofimovich wrote: > Without the change the build fails on upcoming `gcc-15` as: > > In file included from ../src/libcamera/base/file.cpp:8: > ../include/libcamera/base/file.h:62:33: error: 'uint8_t' was not declared in this scope > 62 | ssize_t read(const Span<uint8_t> &data); > | ^~~~~~~ > > Signed-off-by: Sergei Trofimovich <slyich@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/libcamera/base/file.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h > index 5637934c..192668ab 100644 > --- a/include/libcamera/base/file.h > +++ b/include/libcamera/base/file.h > @@ -7,6 +7,7 @@ > > #pragma once > > +#include <stdint.h> > #include <sys/types.h> > > #include <map>
Hi Sergei, thanks for the patch On 04/08/2024 21:55, Sergei Trofimovich wrote: > Without the change the build fails on upcoming `gcc-15` as: > > In file included from ../src/libcamera/base/file.cpp:8: > ../include/libcamera/base/file.h:62:33: error: 'uint8_t' was not declared in this scope > 62 | ssize_t read(const Span<uint8_t> &data); > | ^~~~~~~ > > Signed-off-by: Sergei Trofimovich <slyich@gmail.com> > --- Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> > include/libcamera/base/file.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h > index 5637934c..192668ab 100644 > --- a/include/libcamera/base/file.h > +++ b/include/libcamera/base/file.h > @@ -7,6 +7,7 @@ > > #pragma once > > +#include <stdint.h> > #include <sys/types.h> > > #include <map>
diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h index 5637934c..192668ab 100644 --- a/include/libcamera/base/file.h +++ b/include/libcamera/base/file.h @@ -7,6 +7,7 @@ #pragma once +#include <stdint.h> #include <sys/types.h> #include <map>
Without the change the build fails on upcoming `gcc-15` as: In file included from ../src/libcamera/base/file.cpp:8: ../include/libcamera/base/file.h:62:33: error: 'uint8_t' was not declared in this scope 62 | ssize_t read(const Span<uint8_t> &data); | ^~~~~~~ Signed-off-by: Sergei Trofimovich <slyich@gmail.com> --- include/libcamera/base/file.h | 1 + 1 file changed, 1 insertion(+)