| Message ID | 20240803195505.842-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 0bb8afc9ac9c6fadfae676932ba47f4a1fe33871 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, thank you for the cleanup. Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: > Spaces at end of lines have cropped up in a few places in libcamera. > Remove them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> (The other occurrences either make sense or are copied from elsewhere.) > --- > .clang-format | 4 ++-- > Documentation/coding-style.rst | 2 +- > Documentation/environment_variables.rst | 4 ++-- > src/libcamera/control_ids_core.yaml | 4 ++-- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/.clang-format b/.clang-format > index f2b44e87d4fb..7fc30f614ab1 100644 > --- a/.clang-format > +++ b/.clang-format > @@ -80,7 +80,7 @@ IncludeCategories: > # Headers in <> with an extension. (+system libraries) > - Regex: '<([A-Za-z0-9\-_])+\.h>' > Priority: 2 > - # System headers > + # System headers > - Regex: '<sys/.*>' > Priority: 2 > # C++ standard library includes (no extension) > @@ -100,7 +100,7 @@ IncludeCategories: > # IPA Interfaces > - Regex: '<libcamera/ipa/.*\.h>' > Priority: 7 > - # libcamera Internal headers in "" > + # libcamera Internal headers in "" > - Regex: '"libcamera/internal/.*\.h"' > Priority: 8 > # Other libraries headers with one group per library (.h or .hpp) > diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst > index 72cb28d25189..3352b75c76c8 100644 > --- a/Documentation/coding-style.rst > +++ b/Documentation/coding-style.rst > @@ -215,7 +215,7 @@ shall be avoided when possible, but are allowed when required (for instance to > implement factories with auto-registration). They shall not depend on any other > global variable, should run a minimal amount of code in the constructor and > destructor, and code that contains dependencies should be moved to a later > -point in time. > +point in time. > > Error Handling > ~~~~~~~~~~~~~~ > diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst > index 7cc13e9f3808..de434c386707 100644 > --- a/Documentation/environment_variables.rst > +++ b/Documentation/environment_variables.rst > @@ -39,9 +39,9 @@ LIBCAMERA_IPA_MODULE_PATH > > LIBCAMERA_IPA_PROXY_PATH > Define custom full path for a proxy worker for a given executable name. > - > + > Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker`` > - > + > LIBCAMERA_PIPELINES_MATCH_LIST > Define an ordered list of pipeline names to be used to match the media > devices in the system. The pipeline handler names used to populate the > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > index 9d413a94e0ee..cf40771d3896 100644 > --- a/src/libcamera/control_ids_core.yaml > +++ b/src/libcamera/control_ids_core.yaml > @@ -868,8 +868,8 @@ controls: > - Gamma: > type: float > description: | > - Specify a fixed gamma value. Default must be 2.2 which closely mimics > - sRGB gamma. Note that this is camera gamma, so it is applied as > + Specify a fixed gamma value. Default must be 2.2 which closely mimics > + sRGB gamma. Note that this is camera gamma, so it is applied as > 1.0/gamma. > > ... > > base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5
Quoting Laurent Pinchart (2024-08-03 20:55:05) > Spaces at end of lines have cropped up in a few places in libcamera. > Remove them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > .clang-format | 4 ++-- > Documentation/coding-style.rst | 2 +- > Documentation/environment_variables.rst | 4 ++-- > src/libcamera/control_ids_core.yaml | 4 ++-- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/.clang-format b/.clang-format > index f2b44e87d4fb..7fc30f614ab1 100644 > --- a/.clang-format > +++ b/.clang-format > @@ -80,7 +80,7 @@ IncludeCategories: > # Headers in <> with an extension. (+system libraries) > - Regex: '<([A-Za-z0-9\-_])+\.h>' > Priority: 2 > - # System headers > + # System headers > - Regex: '<sys/.*>' > Priority: 2 > # C++ standard library includes (no extension) > @@ -100,7 +100,7 @@ IncludeCategories: > # IPA Interfaces > - Regex: '<libcamera/ipa/.*\.h>' > Priority: 7 > - # libcamera Internal headers in "" > + # libcamera Internal headers in "" > - Regex: '"libcamera/internal/.*\.h"' > Priority: 8 > # Other libraries headers with one group per library (.h or .hpp) > diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst > index 72cb28d25189..3352b75c76c8 100644 > --- a/Documentation/coding-style.rst > +++ b/Documentation/coding-style.rst > @@ -215,7 +215,7 @@ shall be avoided when possible, but are allowed when required (for instance to > implement factories with auto-registration). They shall not depend on any other > global variable, should run a minimal amount of code in the constructor and > destructor, and code that contains dependencies should be moved to a later > -point in time. > +point in time. > > Error Handling > ~~~~~~~~~~~~~~ > diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst > index 7cc13e9f3808..de434c386707 100644 > --- a/Documentation/environment_variables.rst > +++ b/Documentation/environment_variables.rst > @@ -39,9 +39,9 @@ LIBCAMERA_IPA_MODULE_PATH > > LIBCAMERA_IPA_PROXY_PATH > Define custom full path for a proxy worker for a given executable name. > - > + > Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker`` > - > + > LIBCAMERA_PIPELINES_MATCH_LIST > Define an ordered list of pipeline names to be used to match the media > devices in the system. The pipeline handler names used to populate the > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml > index 9d413a94e0ee..cf40771d3896 100644 > --- a/src/libcamera/control_ids_core.yaml > +++ b/src/libcamera/control_ids_core.yaml > @@ -868,8 +868,8 @@ controls: > - Gamma: > type: float > description: | > - Specify a fixed gamma value. Default must be 2.2 which closely mimics > - sRGB gamma. Note that this is camera gamma, so it is applied as > + Specify a fixed gamma value. Default must be 2.2 which closely mimics > + sRGB gamma. Note that this is camera gamma, so it is applied as > 1.0/gamma. > > ... > > base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5 > -- > Regards, > > Laurent Pinchart >
diff --git a/.clang-format b/.clang-format index f2b44e87d4fb..7fc30f614ab1 100644 --- a/.clang-format +++ b/.clang-format @@ -80,7 +80,7 @@ IncludeCategories: # Headers in <> with an extension. (+system libraries) - Regex: '<([A-Za-z0-9\-_])+\.h>' Priority: 2 - # System headers + # System headers - Regex: '<sys/.*>' Priority: 2 # C++ standard library includes (no extension) @@ -100,7 +100,7 @@ IncludeCategories: # IPA Interfaces - Regex: '<libcamera/ipa/.*\.h>' Priority: 7 - # libcamera Internal headers in "" + # libcamera Internal headers in "" - Regex: '"libcamera/internal/.*\.h"' Priority: 8 # Other libraries headers with one group per library (.h or .hpp) diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst index 72cb28d25189..3352b75c76c8 100644 --- a/Documentation/coding-style.rst +++ b/Documentation/coding-style.rst @@ -215,7 +215,7 @@ shall be avoided when possible, but are allowed when required (for instance to implement factories with auto-registration). They shall not depend on any other global variable, should run a minimal amount of code in the constructor and destructor, and code that contains dependencies should be moved to a later -point in time. +point in time. Error Handling ~~~~~~~~~~~~~~ diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst index 7cc13e9f3808..de434c386707 100644 --- a/Documentation/environment_variables.rst +++ b/Documentation/environment_variables.rst @@ -39,9 +39,9 @@ LIBCAMERA_IPA_MODULE_PATH LIBCAMERA_IPA_PROXY_PATH Define custom full path for a proxy worker for a given executable name. - + Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker`` - + LIBCAMERA_PIPELINES_MATCH_LIST Define an ordered list of pipeline names to be used to match the media devices in the system. The pipeline handler names used to populate the diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml index 9d413a94e0ee..cf40771d3896 100644 --- a/src/libcamera/control_ids_core.yaml +++ b/src/libcamera/control_ids_core.yaml @@ -868,8 +868,8 @@ controls: - Gamma: type: float description: | - Specify a fixed gamma value. Default must be 2.2 which closely mimics - sRGB gamma. Note that this is camera gamma, so it is applied as + Specify a fixed gamma value. Default must be 2.2 which closely mimics + sRGB gamma. Note that this is camera gamma, so it is applied as 1.0/gamma. ...
Spaces at end of lines have cropped up in a few places in libcamera. Remove them. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .clang-format | 4 ++-- Documentation/coding-style.rst | 2 +- Documentation/environment_variables.rst | 4 ++-- src/libcamera/control_ids_core.yaml | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) base-commit: 19bbca3c0b376ba0183f5db53472c8c46cd402b5