| Message ID | 20240730232708.17399-4-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, thank you for taking care of this. Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: > The file seal TODO item has been addressed. Remove it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > --- > src/libcamera/software_isp/TODO | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO > index 6bdc590531ca..9978afc0317b 100644 > --- a/src/libcamera/software_isp/TODO > +++ b/src/libcamera/software_isp/TODO > @@ -1,22 +1,3 @@ > -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate() > - > ->> SharedMem::SharedMem(const std::string &name, std::size_t size) > ->> : name_(name), size_(size), mem_(nullptr) > ->> > ->> ... > ->> > ->> if (ftruncate(fd_.get(), size_) < 0) > ->> return; > -> > -> Should we set the GROW and SHRINK seals (in a separate patch) ? > - > -Yes, this can be done. > -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch > -some potential errors related to improper access to the shared memory allocated by > -the SharedMemObject. > - > ---- > - > 2. Reconsider stats sharing > > >>> +void SwStatsCpu::finishFrame(void)
Quoting Milan Zamazal (2024-07-31 08:26:03) > Hi Laurent, > > thank you for taking care of this. > > Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: > > > The file seal TODO item has been addressed. Remove it. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > src/libcamera/software_isp/TODO | 19 ------------------- > > 1 file changed, 19 deletions(-) > > > > diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO > > index 6bdc590531ca..9978afc0317b 100644 > > --- a/src/libcamera/software_isp/TODO > > +++ b/src/libcamera/software_isp/TODO > > @@ -1,22 +1,3 @@ > > -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate() > > - > > ->> SharedMem::SharedMem(const std::string &name, std::size_t size) > > ->> : name_(name), size_(size), mem_(nullptr) > > ->> > > ->> ... > > ->> > > ->> if (ftruncate(fd_.get(), size_) < 0) > > ->> return; > > -> > > -> Should we set the GROW and SHRINK seals (in a separate patch) ? > > - > > -Yes, this can be done. > > -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch > > -some potential errors related to improper access to the shared memory allocated by > > -the SharedMemObject. > > - > > ---- > > - > > 2. Reconsider stats sharing > > > > >>> +void SwStatsCpu::finishFrame(void) >
diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO index 6bdc590531ca..9978afc0317b 100644 --- a/src/libcamera/software_isp/TODO +++ b/src/libcamera/software_isp/TODO @@ -1,22 +1,3 @@ -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate() - ->> SharedMem::SharedMem(const std::string &name, std::size_t size) ->> : name_(name), size_(size), mem_(nullptr) ->> ->> ... ->> ->> if (ftruncate(fd_.get(), size_) < 0) ->> return; -> -> Should we set the GROW and SHRINK seals (in a separate patch) ? - -Yes, this can be done. -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch -some potential errors related to improper access to the shared memory allocated by -the SharedMemObject. - ---- - 2. Reconsider stats sharing >>> +void SwStatsCpu::finishFrame(void)
The file seal TODO item has been addressed. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/software_isp/TODO | 19 ------------------- 1 file changed, 19 deletions(-)