Document additional environmental variables
diff mbox series

Message ID 20240727051805.9366-1-pablo.pita@gmail.com
State Accepted
Commit 19bbca3c0b376ba0183f5db53472c8c46cd402b5
Headers show
Series
  • Document additional environmental variables
Related show

Commit Message

Pablo Pita July 27, 2024, 5:18 a.m. UTC
* LIBCAMERA_IPA_PROXY_PATH: path to access a proxy IPA
* LIBCAMERA_RPI_TUNING_FILE: used to pass tuning configuration data for the raspberry pi

Signed-off-by: Pablo Pita <pablo.pita@gmail.com>
---
 Documentation/environment_variables.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Kieran Bingham July 31, 2024, 11:57 a.m. UTC | #1
Quoting Pablo Pita (2024-07-27 06:18:05)
> * LIBCAMERA_IPA_PROXY_PATH: path to access a proxy IPA
> * LIBCAMERA_RPI_TUNING_FILE: used to pass tuning configuration data for the raspberry pi
> 
> Signed-off-by: Pablo Pita <pablo.pita@gmail.com>

I think you could have kept both of mine and Jacopo's RB tags for this
so I'm going to add them both (Jacopo, please let me know if you
object!)

From v1:


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  Documentation/environment_variables.rst | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst
> index 4e9fbb27..7cc13e9f 100644
> --- a/Documentation/environment_variables.rst
> +++ b/Documentation/environment_variables.rst
> @@ -37,6 +37,11 @@ LIBCAMERA_IPA_MODULE_PATH
>  
>     Example value: ``${HOME}/.libcamera/lib:/opt/libcamera/vendor/lib``
>  
> +LIBCAMERA_IPA_PROXY_PATH
> +   Define custom full path for a proxy worker for a given executable name.
> +   
> +   Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker``
> +   
>  LIBCAMERA_PIPELINES_MATCH_LIST
>     Define an ordered list of pipeline names to be used to match the media
>     devices in the system. The pipeline handler names used to populate the
> @@ -50,6 +55,11 @@ LIBCAMERA_RPI_CONFIG_FILE
>  
>     Example value: ``/usr/local/share/libcamera/pipeline/rpi/vc4/minimal_mem.yaml``
>  
> +LIBCAMERA_RPI_TUNING_FILE
> +   Define a custom JSON tuning file to use in the Raspberry Pi.
> +
> +   Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``
> +
>  Further details
>  ---------------
>  
> -- 
> 2.43.0
>
Pablo Pita July 31, 2024, 12:04 p.m. UTC | #2
No problem to add previous Jacopo's RB tags. I am happy to see this
documentation added.

On Wed, 31 Jul 2024 at 13:57, Kieran Bingham <
kieran.bingham@ideasonboard.com> wrote:

> Quoting Pablo Pita (2024-07-27 06:18:05)
> > * LIBCAMERA_IPA_PROXY_PATH: path to access a proxy IPA
> > * LIBCAMERA_RPI_TUNING_FILE: used to pass tuning configuration data for
> the raspberry pi
> >
> > Signed-off-by: Pablo Pita <pablo.pita@gmail.com>
>
> I think you could have kept both of mine and Jacopo's RB tags for this
> so I'm going to add them both (Jacopo, please let me know if you
> object!)
>
> From v1:
>
>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
> > ---
> >  Documentation/environment_variables.rst | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/Documentation/environment_variables.rst
> b/Documentation/environment_variables.rst
> > index 4e9fbb27..7cc13e9f 100644
> > --- a/Documentation/environment_variables.rst
> > +++ b/Documentation/environment_variables.rst
> > @@ -37,6 +37,11 @@ LIBCAMERA_IPA_MODULE_PATH
> >
> >     Example value: ``${HOME}/.libcamera/lib:/opt/libcamera/vendor/lib``
> >
> > +LIBCAMERA_IPA_PROXY_PATH
> > +   Define custom full path for a proxy worker for a given executable
> name.
> > +
> > +   Example value:
> ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker``
> > +
> >  LIBCAMERA_PIPELINES_MATCH_LIST
> >     Define an ordered list of pipeline names to be used to match the
> media
> >     devices in the system. The pipeline handler names used to populate
> the
> > @@ -50,6 +55,11 @@ LIBCAMERA_RPI_CONFIG_FILE
> >
> >     Example value:
> ``/usr/local/share/libcamera/pipeline/rpi/vc4/minimal_mem.yaml``
> >
> > +LIBCAMERA_RPI_TUNING_FILE
> > +   Define a custom JSON tuning file to use in the Raspberry Pi.
> > +
> > +   Example value:
> ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``
> > +
> >  Further details
> >  ---------------
> >
> > --
> > 2.43.0
> >
>
Kieran Bingham Aug. 1, 2024, 2:13 p.m. UTC | #3
Hello, this is a notification that patchwork/4463 has been merged.

Patch
diff mbox series

diff --git a/Documentation/environment_variables.rst b/Documentation/environment_variables.rst
index 4e9fbb27..7cc13e9f 100644
--- a/Documentation/environment_variables.rst
+++ b/Documentation/environment_variables.rst
@@ -37,6 +37,11 @@  LIBCAMERA_IPA_MODULE_PATH
 
    Example value: ``${HOME}/.libcamera/lib:/opt/libcamera/vendor/lib``
 
+LIBCAMERA_IPA_PROXY_PATH
+   Define custom full path for a proxy worker for a given executable name.
+   
+   Example value: ``${HOME}/.libcamera/proxy/worker:/opt/libcamera/vendor/proxy/worker``
+   
 LIBCAMERA_PIPELINES_MATCH_LIST
    Define an ordered list of pipeline names to be used to match the media
    devices in the system. The pipeline handler names used to populate the
@@ -50,6 +55,11 @@  LIBCAMERA_RPI_CONFIG_FILE
 
    Example value: ``/usr/local/share/libcamera/pipeline/rpi/vc4/minimal_mem.yaml``
 
+LIBCAMERA_RPI_TUNING_FILE
+   Define a custom JSON tuning file to use in the Raspberry Pi.
+
+   Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``
+
 Further details
 ---------------