[v3,03/23] libcamera: vimc: Drop ipa_interface.h header
diff mbox series

Message ID 20240717085444.289997-4-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Software ISP refactoring
Related show

Commit Message

Milan Zamazal July 17, 2024, 8:54 a.m. UTC 
From: Umang Jain <umang.jain@ideasonboard.com>

The ipa_interface.h header is already included in vimc_ipa_interface.h
generated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA
and pipeline handler as deemed redundant.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/ipa/vimc/vimc.cpp                | 1 -
 src/libcamera/pipeline/vimc/vimc.cpp | 1 -
 2 files changed, 2 deletions(-)

Comments

Laurent Pinchart Aug. 12, 2024, 12:27 p.m. UTC | #1 
On Wed, Jul 17, 2024 at 10:54:24AM +0200, Milan Zamazal wrote:
> From: Umang Jain <umang.jain@ideasonboard.com>
> 
> The ipa_interface.h header is already included in vimc_ipa_interface.h
> generated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA
> and pipeline handler as deemed redundant.

As for 01/23, the first hunk should be dropped, and the commit message
should be updated.

> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  src/ipa/vimc/vimc.cpp                | 1 -
>  src/libcamera/pipeline/vimc/vimc.cpp | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp
> index ebd63fa6..766e9c9c 100644
> --- a/src/ipa/vimc/vimc.cpp
> +++ b/src/ipa/vimc/vimc.cpp
> @@ -16,7 +16,6 @@
>  #include <libcamera/base/file.h>
>  #include <libcamera/base/log.h>
>  
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  
>  #include "libcamera/internal/mapped_framebuffer.h"
> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp
> index 0ec9928e..838a9355 100644
> --- a/src/libcamera/pipeline/vimc/vimc.cpp
> +++ b/src/libcamera/pipeline/vimc/vimc.cpp
> @@ -24,7 +24,6 @@
>  #include <libcamera/request.h>
>  #include <libcamera/stream.h>
>  
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/vimc_ipa_interface.h>
>  #include <libcamera/ipa/vimc_ipa_proxy.h>

Patch
diff mbox series 

diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp
index ebd63fa6..766e9c9c 100644
--- a/src/ipa/vimc/vimc.cpp
+++ b/src/ipa/vimc/vimc.cpp
@@ -16,7 +16,6 @@ 
 #include <libcamera/base/file.h>
 #include <libcamera/base/log.h>
 
-#include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 
 #include "libcamera/internal/mapped_framebuffer.h"
diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp
index 0ec9928e..838a9355 100644
--- a/src/libcamera/pipeline/vimc/vimc.cpp
+++ b/src/libcamera/pipeline/vimc/vimc.cpp
@@ -24,7 +24,6 @@ 
 #include <libcamera/request.h>
 #include <libcamera/stream.h>
 
-#include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 #include <libcamera/ipa/vimc_ipa_interface.h>
 #include <libcamera/ipa/vimc_ipa_proxy.h>