[v3,04/23] libcamera: ipa: soft_simple: Drop ipa_interface.h header
diff mbox series

Message ID 20240717085444.289997-5-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Software ISP refactoring
Related show

Commit Message

Milan Zamazal July 17, 2024, 8:54 a.m. UTC 
From: Umang Jain <umang.jain@ideasonboard.com>

The ipa_interface.h header is already included in soft_ipa_interface.h
generated from module_ipa_interface.h.tmpl. Drop it from software-isp
IPA as deemed redundant.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/ipa/simple/soft_simple.cpp | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart Aug. 12, 2024, 12:28 p.m. UTC | #1 
On Wed, Jul 17, 2024 at 10:54:25AM +0200, Milan Zamazal wrote:
> From: Umang Jain <umang.jain@ideasonboard.com>
> 
> The ipa_interface.h header is already included in soft_ipa_interface.h
> generated from module_ipa_interface.h.tmpl. Drop it from software-isp
> IPA as deemed redundant.

For the reason explained in 01/23, this patch should be dropped.

> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  src/ipa/simple/soft_simple.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp
> index b7746ce0..3cc873a2 100644
> --- a/src/ipa/simple/soft_simple.cpp
> +++ b/src/ipa/simple/soft_simple.cpp
> @@ -19,7 +19,6 @@
>  #include <libcamera/control_ids.h>
>  #include <libcamera/controls.h>
>  
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/soft_ipa_interface.h>
>

Patch
diff mbox series 

diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp
index b7746ce0..3cc873a2 100644
--- a/src/ipa/simple/soft_simple.cpp
+++ b/src/ipa/simple/soft_simple.cpp
@@ -19,7 +19,6 @@ 
 #include <libcamera/control_ids.h>
 #include <libcamera/controls.h>
 
-#include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 #include <libcamera/ipa/soft_ipa_interface.h>