[v3,05/23] libcamera: software_isp: Remove superfluous includes

20664 diff mbox series

Remove unused libcamera internal headers bayer_format.h, framebuffer.h
and mapped_frameBuffer.h.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/libcamera/software_isp/software_isp.cpp | 3 ---
 1 file changed, 3 deletions(-)

Hi Milan,

Thank you for the patch.

On Wed, Jul 17, 2024 at 10:54:26AM +0200, Milan Zamazal wrote:
> Remove unused libcamera internal headers bayer_format.h, framebuffer.h
> and mapped_frameBuffer.h.
> 
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  src/libcamera/software_isp/software_isp.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index c8748d88..a7e9058e 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -16,10 +16,7 @@
>  #include <libcamera/formats.h>
>  #include <libcamera/stream.h>
>  
> -#include "libcamera/internal/bayer_format.h"

Looks good.

> -#include "libcamera/internal/framebuffer.h"

This file uses the FrameBuffer class, let's not depend on indirect
inclusion.

>  #include "libcamera/internal/ipa_manager.h"
> -#include "libcamera/internal/mapped_framebuffer.h"

This looks good to.

With framebuffer.h retained (and the commit message updated
accordingly),

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  #include "libcamera/internal/software_isp/debayer_params.h"
>  
>  #include "debayer_cpu.h"

Hi Milan, thanks for the series

On 17/07/2024 09:54, Milan Zamazal wrote:
> Remove unused libcamera internal headers bayer_format.h, framebuffer.h
> and mapped_frameBuffer.h.
>
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>   src/libcamera/software_isp/software_isp.cpp | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index c8748d88..a7e9058e 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -16,10 +16,7 @@
>   #include <libcamera/formats.h>
>   #include <libcamera/stream.h>
>   
> -#include "libcamera/internal/bayer_format.h"
> -#include "libcamera/internal/framebuffer.h"
>   #include "libcamera/internal/ipa_manager.h"
> -#include "libcamera/internal/mapped_framebuffer.h"
>   #include "libcamera/internal/software_isp/debayer_params.h"
>   
>   #include "debayer_cpu.h"

Hi Laurent

On 12/08/2024 13:31, Laurent Pinchart wrote:
> Hi Milan,
>
> Thank you for the patch.
>
> On Wed, Jul 17, 2024 at 10:54:26AM +0200, Milan Zamazal wrote:
>> Remove unused libcamera internal headers bayer_format.h, framebuffer.h
>> and mapped_frameBuffer.h.
>>
>> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
>> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
>> ---
>>   src/libcamera/software_isp/software_isp.cpp | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
>> index c8748d88..a7e9058e 100644
>> --- a/src/libcamera/software_isp/software_isp.cpp
>> +++ b/src/libcamera/software_isp/software_isp.cpp
>> @@ -16,10 +16,7 @@
>>   #include <libcamera/formats.h>
>>   #include <libcamera/stream.h>
>>   
>> -#include "libcamera/internal/bayer_format.h"
> Looks good.
>
>> -#include "libcamera/internal/framebuffer.h"
> This file uses the FrameBuffer class, let's not depend on indirect
> inclusion.
It uses the public rather than private FrameBuffer though...but ah, it's missing the inclusion of 
the public header
>
>>   #include "libcamera/internal/ipa_manager.h"
>> -#include "libcamera/internal/mapped_framebuffer.h"
> This looks good to.
>
> With framebuffer.h retained (and the commit message updated
> accordingly),
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>>   #include "libcamera/internal/software_isp/debayer_params.h"
>>   
>>   #include "debayer_cpu.h"

On Mon, Aug 12, 2024 at 02:03:41PM +0100, Daniel Scally wrote:
> On 12/08/2024 13:31, Laurent Pinchart wrote:
> > On Wed, Jul 17, 2024 at 10:54:26AM +0200, Milan Zamazal wrote:
> >> Remove unused libcamera internal headers bayer_format.h, framebuffer.h
> >> and mapped_frameBuffer.h.
> >>
> >> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> >> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> >> ---
> >>   src/libcamera/software_isp/software_isp.cpp | 3 ---
> >>   1 file changed, 3 deletions(-)
> >>
> >> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> >> index c8748d88..a7e9058e 100644
> >> --- a/src/libcamera/software_isp/software_isp.cpp
> >> +++ b/src/libcamera/software_isp/software_isp.cpp
> >> @@ -16,10 +16,7 @@
> >>   #include <libcamera/formats.h>
> >>   #include <libcamera/stream.h>
> >>   
> >> -#include "libcamera/internal/bayer_format.h"
> >
> > Looks good.
> >
> >> -#include "libcamera/internal/framebuffer.h"
> >
> > This file uses the FrameBuffer class, let's not depend on indirect
> > inclusion.
>
> It uses the public rather than private FrameBuffer though...but ah, it's missing the inclusion of 
> the public header

Ah good point. That's a separate issue, this patch is fine as-is.

> >>   #include "libcamera/internal/ipa_manager.h"
> >> -#include "libcamera/internal/mapped_framebuffer.h"
> >
> > This looks good to.
> >
> > With framebuffer.h retained (and the commit message updated
> > accordingly),
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> >>   #include "libcamera/internal/software_isp/debayer_params.h"
> >>   
> >>   #include "debayer_cpu.h"