[RFC,2/6] include: linux: Update headers for Dw100 dewarper engine
diff mbox series

Message ID 20240712052920.33396-3-umang.jain@ideasonboard.com
State Not Applicable
Headers show
Series
  • converter_dw100: Add vertex map support
Related show

Commit Message

Umang Jain July 12, 2024, 5:29 a.m. UTC 
From: Xavier Roumegue <xavier.roumegue@oss.nxp.com>

Include the DW100 dewarper header as part of linux headers.
It will be used to set the V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP
control by ConverterDW100

Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 include/linux/dw100.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 include/linux/dw100.h

Comments

Jacopo Mondi July 24, 2024, 1:12 p.m. UTC | #1 
Hi Umang

On Fri, Jul 12, 2024 at 10:59:16AM GMT, Umang Jain wrote:
> From: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
>
> Include the DW100 dewarper header as part of linux headers.
> It will be used to set the V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP
> control by ConverterDW100

A reference to the Linux kernel version this header comes from might
be apreciated.

With that
Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

>
> Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  include/linux/dw100.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 include/linux/dw100.h
>
> diff --git a/include/linux/dw100.h b/include/linux/dw100.h
> new file mode 100644
> index 00000000..3356496e
> --- /dev/null
> +++ b/include/linux/dw100.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> +/* Copyright 2022 NXP */
> +
> +#ifndef __UAPI_DW100_H__
> +#define __UAPI_DW100_H__
> +
> +#include <linux/v4l2-controls.h>
> +
> +/*
> + * Check Documentation/userspace-api/media/drivers/dw100.rst for control details.
> + */
> +#define V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP (V4L2_CID_USER_DW100_BASE + 1)
> +
> +#endif
> --
> 2.45.0
>
Kieran Bingham July 24, 2024, 5:05 p.m. UTC | #2 
Quoting Jacopo Mondi (2024-07-24 14:12:11)
> Hi Umang
> 
> On Fri, Jul 12, 2024 at 10:59:16AM GMT, Umang Jain wrote:
> > From: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
> >
> > Include the DW100 dewarper header as part of linux headers.
> > It will be used to set the V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP
> > control by ConverterDW100
> 
> A reference to the Linux kernel version this header comes from might
> be apreciated.
> 
> With that
> Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

This probably needs an addition to utils/update-kernel-headers.sh and to
be updated using that script too!

--
Kieran


> 
> >
> > Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
> > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> > ---
> >  include/linux/dw100.h | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 include/linux/dw100.h
> >
> > diff --git a/include/linux/dw100.h b/include/linux/dw100.h
> > new file mode 100644
> > index 00000000..3356496e
> > --- /dev/null
> > +++ b/include/linux/dw100.h
> > @@ -0,0 +1,14 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> > +/* Copyright 2022 NXP */
> > +
> > +#ifndef __UAPI_DW100_H__
> > +#define __UAPI_DW100_H__
> > +
> > +#include <linux/v4l2-controls.h>
> > +
> > +/*
> > + * Check Documentation/userspace-api/media/drivers/dw100.rst for control details.
> > + */
> > +#define V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP (V4L2_CID_USER_DW100_BASE + 1)
> > +
> > +#endif
> > --
> > 2.45.0
> >
Laurent Pinchart Aug. 2, 2024, 10:29 p.m. UTC | #3 
On Wed, Jul 24, 2024 at 06:05:27PM +0100, Kieran Bingham wrote:
> Quoting Jacopo Mondi (2024-07-24 14:12:11)
> > Hi Umang
> > 
> > On Fri, Jul 12, 2024 at 10:59:16AM GMT, Umang Jain wrote:
> > > From: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
> > >
> > > Include the DW100 dewarper header as part of linux headers.
> > > It will be used to set the V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP
> > > control by ConverterDW100
> > 
> > A reference to the Linux kernel version this header comes from might
> > be apreciated.
> > 
> > With that
> > Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> 
> This probably needs an addition to utils/update-kernel-headers.sh and to
> be updated using that script too!

I was about to write the same :-)

> > > Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
> > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> > > ---
> > >  include/linux/dw100.h | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > >  create mode 100644 include/linux/dw100.h
> > >
> > > diff --git a/include/linux/dw100.h b/include/linux/dw100.h
> > > new file mode 100644
> > > index 00000000..3356496e
> > > --- /dev/null
> > > +++ b/include/linux/dw100.h
> > > @@ -0,0 +1,14 @@
> > > +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> > > +/* Copyright 2022 NXP */
> > > +
> > > +#ifndef __UAPI_DW100_H__
> > > +#define __UAPI_DW100_H__
> > > +
> > > +#include <linux/v4l2-controls.h>
> > > +
> > > +/*
> > > + * Check Documentation/userspace-api/media/drivers/dw100.rst for control details.
> > > + */
> > > +#define V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP (V4L2_CID_USER_DW100_BASE + 1)
> > > +
> > > +#endif

Patch
diff mbox series 

diff --git a/include/linux/dw100.h b/include/linux/dw100.h
new file mode 100644
index 00000000..3356496e
--- /dev/null
+++ b/include/linux/dw100.h
@@ -0,0 +1,14 @@ 
+/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
+/* Copyright 2022 NXP */
+
+#ifndef __UAPI_DW100_H__
+#define __UAPI_DW100_H__
+
+#include <linux/v4l2-controls.h>
+
+/*
+ * Check Documentation/userspace-api/media/drivers/dw100.rst for control details.
+ */
+#define V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP (V4L2_CID_USER_DW100_BASE + 1)
+
+#endif