[resend,2/2] libcamera: pipeline: simple: Enable simplepipeline for intel-ipu6
diff mbox series

Message ID 20240703150923.25994-2-hdegoede@redhat.com
State Superseded
Headers show
Series
  • [resend,1/2] libcamera: v4l2_videodevice: Fix devices which set both V4L2_CAP_VIDEO and V4L2_CAP_META
Related show

Commit Message

Hans de Goede July 3, 2024, 3:09 p.m. UTC 
From: Dennis Bonke <admin@dennisbonke.com>

Enable the simple pipeline handler with software ISP for the IPU6
now that te IPU6 CSI2 receiver (aka the isys driver) has landed
in media_staging/master.

Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 src/libcamera/pipeline/simple/simple.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart July 3, 2024, 3:18 p.m. UTC | #1 
Hi Hans and Dennis,

Thank you for the patch.

On Wed, Jul 03, 2024 at 05:09:23PM +0200, Hans de Goede wrote:
> From: Dennis Bonke <admin@dennisbonke.com>
> 
> Enable the simple pipeline handler with software ISP for the IPU6
> now that te IPU6 CSI2 receiver (aka the isys driver) has landed

s/that te/that the/

> in media_staging/master.
> 
> Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 5eb1dd21..60aafc4e 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -198,6 +198,7 @@ namespace {
>  static const SimplePipelineInfo supportedDevices[] = {
>  	{ "dcmipp", {}, false },
>  	{ "imx7-csi", { { "pxp", 1 } }, false },
> +	{ "intel-ipu6", {}, true },
>  	{ "j721e-csi2rx", {}, false },
>  	{ "mtk-seninf", { { "mtk-mdp", 3 } }, false },
>  	{ "mxc-isi", {}, false },
Umang Jain July 4, 2024, 4:28 a.m. UTC | #2 
Hello all,

On 03/07/24 8:48 pm, Laurent Pinchart wrote:
> Hi Hans and Dennis,
>
> Thank you for the patch.
>
> On Wed, Jul 03, 2024 at 05:09:23PM +0200, Hans de Goede wrote:
>> From: Dennis Bonke <admin@dennisbonke.com>
>>
>> Enable the simple pipeline handler with software ISP for the IPU6
>> now that te IPU6 CSI2 receiver (aka the isys driver) has landed
> s/that te/that the/
>
>> in media_staging/master.
>>
>> Signed-off-by: Dennis Bonke <admin@dennisbonke.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
In subject,

s/simplepipeline/simple pipeline/

or can be better rephrased to,

libcamera: pipeline: simple: Enable intel-ipu6 with Soft ISP

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
>
>> ---
>>   src/libcamera/pipeline/simple/simple.cpp | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
>> index 5eb1dd21..60aafc4e 100644
>> --- a/src/libcamera/pipeline/simple/simple.cpp
>> +++ b/src/libcamera/pipeline/simple/simple.cpp
>> @@ -198,6 +198,7 @@ namespace {
>>   static const SimplePipelineInfo supportedDevices[] = {
>>   	{ "dcmipp", {}, false },
>>   	{ "imx7-csi", { { "pxp", 1 } }, false },
>> +	{ "intel-ipu6", {}, true },
>>   	{ "j721e-csi2rx", {}, false },
>>   	{ "mtk-seninf", { { "mtk-mdp", 3 } }, false },
>>   	{ "mxc-isi", {}, false },

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
index 5eb1dd21..60aafc4e 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -198,6 +198,7 @@  namespace {
 static const SimplePipelineInfo supportedDevices[] = {
 	{ "dcmipp", {}, false },
 	{ "imx7-csi", { { "pxp", 1 } }, false },
+	{ "intel-ipu6", {}, true },
 	{ "j721e-csi2rx", {}, false },
 	{ "mtk-seninf", { { "mtk-mdp", 3 } }, false },
 	{ "mxc-isi", {}, false },