[v3,23/23] libtuning: agc: rkisp1: Increase y-target
diff mbox series

Message ID 20240703141726.252368-24-stefan.klug@ideasonboard.com
State Superseded
Headers show
Series
  • Add ccm calibration to libtuning
Related show

Commit Message

Stefan Klug July 3, 2024, 2:17 p.m. UTC 
With the addition of gamma out correction the relative luminance target
was set too low. As brightness is a bit subjective it is difficult to
come up with the "correct" value. With 0.5 the patch 22 on the mac beth
chart (neutral grey, 18% reflectance) ended up a bit below 50% grey,
which seems reasonable.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Elder July 5, 2024, 6:29 a.m. UTC | #1 
On Wed, Jul 03, 2024 at 04:17:12PM +0200, Stefan Klug wrote:
> With the addition of gamma out correction the relative luminance target
> was set too low. As brightness is a bit subjective it is difficult to
> come up with the "correct" value. With 0.5 the patch 22 on the mac beth

s/mac beth/macbeth/

> chart (neutral grey, 18% reflectance) ended up a bit below 50% grey,
> which seems reasonable.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py
> index 19a5555b6111..7147028a774a 100644
> --- a/utils/tuning/libtuning/modules/agc/rkisp1.py
> +++ b/utils/tuning/libtuning/modules/agc/rkisp1.py
> @@ -64,7 +64,7 @@ class AGCRkISP1(AGC):
>          return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}
>  
>      def _generate_y_target(self) -> list:
> -        return 0.16
> +        return 0.5
>  
>      def process(self, config: dict, images: list, outputs: dict) -> dict:
>          output = {}
> -- 
> 2.43.0
>

Patch
diff mbox series 

diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py
index 19a5555b6111..7147028a774a 100644
--- a/utils/tuning/libtuning/modules/agc/rkisp1.py
+++ b/utils/tuning/libtuning/modules/agc/rkisp1.py
@@ -64,7 +64,7 @@  class AGCRkISP1(AGC):
         return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}
 
     def _generate_y_target(self) -> list:
-        return 0.16
+        return 0.5
 
     def process(self, config: dict, images: list, outputs: dict) -> dict:
         output = {}