[v3,17/23] libtuning: Handle cases, where no lsc tuning images are present
diff mbox series

Message ID 20240703141726.252368-18-stefan.klug@ideasonboard.com
State Superseded
Headers show
Series
  • Add ccm calibration to libtuning
Related show

Commit Message

Stefan Klug July 3, 2024, 2:17 p.m. UTC 
Make it clear that no lsc calibration was done by returning None instead
of a incomplete configuration.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++
 1 file changed, 3 insertions(+)

Comments

Paul Elder July 4, 2024, 10:30 a.m. UTC | #1 
On Wed, Jul 03, 2024 at 04:17:06PM +0200, Stefan Klug wrote:
> Make it clear that no lsc calibration was done by returning None instead
> of a incomplete configuration.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> index 57004104fc7a..512233aeae9d 100644
> --- a/utils/tuning/libtuning/modules/lsc/rkisp1.py
> +++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> @@ -107,6 +107,9 @@ class LSCRkISP1(LSC):
>  
>          output['sets'] = self._do_all_lsc(images)
>  
> +        if len(output['sets']) == 0:
> +            return None
> +
>          # \todo Validate images from greyscale camera and force grescale mode
>          # \todo Debug functionality
>  
> -- 
> 2.43.0
>

Patch
diff mbox series 

diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py
index 57004104fc7a..512233aeae9d 100644
--- a/utils/tuning/libtuning/modules/lsc/rkisp1.py
+++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py
@@ -107,6 +107,9 @@  class LSCRkISP1(LSC):
 
         output['sets'] = self._do_all_lsc(images)
 
+        if len(output['sets']) == 0:
+            return None
+
         # \todo Validate images from greyscale camera and force grescale mode
         # \todo Debug functionality