[2/4] libcamera: ipa: ipu3: Drop ipa_interface.h header
diff mbox series

Message ID 20240701075720.46076-3-umang.jain@ideasonboard.com
State Not Applicable
Headers show
Series
  • Frop base IPA headers
Related show

Commit Message

Umang Jain July 1, 2024, 7:57 a.m. UTC 
The ipa_interface.h header is already included in ipu3_ipa_interface.h
generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/ipa/ipu3/ipu3.cpp | 1 -
 1 file changed, 1 deletion(-)

Comments

Milan Zamazal July 1, 2024, 9:03 a.m. UTC | #1 
Umang Jain <umang.jain@ideasonboard.com> writes:

> The ipa_interface.h header is already included in ipu3_ipa_interface.h
> generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.
>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/ipa/ipu3/ipu3.cpp | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index cdcdf1fb..dca07970 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -24,7 +24,6 @@
>  
>  #include <libcamera/control_ids.h>
>  #include <libcamera/framebuffer.h>
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/ipu3_ipa_interface.h>
>  #include <libcamera/request.h>
Kieran Bingham July 1, 2024, 9:47 a.m. UTC | #2 
Quoting Umang Jain (2024-07-01 08:57:18)
> The ipa_interface.h header is already included in ipu3_ipa_interface.h
> generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index cdcdf1fb..dca07970 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -24,7 +24,6 @@
>  
>  #include <libcamera/control_ids.h>
>  #include <libcamera/framebuffer.h>
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/ipu3_ipa_interface.h>

Indeed, this is the interface!


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>  #include <libcamera/request.h>
> -- 
> 2.44.0
>

Patch
diff mbox series 

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index cdcdf1fb..dca07970 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -24,7 +24,6 @@ 
 
 #include <libcamera/control_ids.h>
 #include <libcamera/framebuffer.h>
-#include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 #include <libcamera/ipa/ipu3_ipa_interface.h>
 #include <libcamera/request.h>