[v3,3/9] libcamera: mali-c55: Init camera properties
diff mbox series

Message ID 20240626140309.50052-4-jacopo.mondi@ideasonboard.com
State Superseded
Headers show
Series
  • Miscellaneous Mali-C55 Pipeline Fixes
Related show

Commit Message

Jacopo Mondi June 26, 2024, 2:02 p.m. UTC 
From: Daniel Scally <dan.scally@ideasonboard.com>

Initialise the camera properties using the CameraSensor properties.

Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Umang Jain June 29, 2024, 6:45 a.m. UTC | #1 
Hi Dan and Jacopo,

On 26/06/24 7:32 pm, Jacopo Mondi wrote:
> From: Daniel Scally <dan.scally@ideasonboard.com>
>
> Initialise the camera properties using the CameraSensor properties.
>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

LGTM,
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>   src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> index d1ae1a61d5a9..bffd842c2af1 100644
> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> @@ -965,7 +965,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)
>   		if (data->init())
>   			return false;
>   
> -		/* \todo: Init properties and controls. */
> +		data->properties_ = data->sensor_->properties();
>   
>   		registerMaliCamera(std::move(data), sensor->name());
>   	}

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
index d1ae1a61d5a9..bffd842c2af1 100644
--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
@@ -965,7 +965,7 @@  bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)
 		if (data->init())
 			return false;
 
-		/* \todo: Init properties and controls. */
+		data->properties_ = data->sensor_->properties();
 
 		registerMaliCamera(std::move(data), sensor->name());
 	}