[01/19] libcamera: software_isp: Remove superfluous includes
diff mbox series

Message ID 20240626072100.55497-2-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Software ISP refactoring
Related show

Commit Message

Milan Zamazal June 26, 2024, 7:20 a.m. UTC
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/libcamera/software_isp/software_isp.cpp | 3 ---
 1 file changed, 3 deletions(-)

Comments

Umang Jain June 28, 2024, 3:30 a.m. UTC | #1
Hi Milan,

Thank you for the patch.

On 26/06/24 12:50 pm, Milan Zamazal wrote:
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>

nit: One line in commit message body is usually nice-to-have. For instance,

"Remove unused libcamera internal headers bayer_format.h, framebuffer.h 
and mapped_frameBuffer.h."

Otherwise,

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>   src/libcamera/software_isp/software_isp.cpp | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index 20fb6f48..08a1afcc 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -16,10 +16,7 @@
>   #include <libcamera/formats.h>
>   #include <libcamera/stream.h>
>   
> -#include "libcamera/internal/bayer_format.h"
> -#include "libcamera/internal/framebuffer.h"
>   #include "libcamera/internal/ipa_manager.h"
> -#include "libcamera/internal/mapped_framebuffer.h"
>   #include "libcamera/internal/software_isp/debayer_params.h"
>   
>   #include "debayer_cpu.h"

Patch
diff mbox series

diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
index 20fb6f48..08a1afcc 100644
--- a/src/libcamera/software_isp/software_isp.cpp
+++ b/src/libcamera/software_isp/software_isp.cpp
@@ -16,10 +16,7 @@ 
 #include <libcamera/formats.h>
 #include <libcamera/stream.h>
 
-#include "libcamera/internal/bayer_format.h"
-#include "libcamera/internal/framebuffer.h"
 #include "libcamera/internal/ipa_manager.h"
-#include "libcamera/internal/mapped_framebuffer.h"
 #include "libcamera/internal/software_isp/debayer_params.h"
 
 #include "debayer_cpu.h"