[03/12] ipa: libipa: agc_mean_luminance: Include missing header
diff mbox series

Message ID 20240616163910.5506-4-laurent.pinchart@ideasonboard.com
State Accepted
Commit 8b82a7f1e739b9cb5a796532b865ce66b31f41bb
Headers show
Series
  • ipa: rkisp1: Miscellaneous AGC fixes
Related show

Commit Message

Laurent Pinchart June 16, 2024, 4:39 p.m. UTC
agc_mean_luminance.h uses utils::Duration, include the corresponding
header.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/libipa/agc_mean_luminance.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kieran Bingham June 17, 2024, 8:58 a.m. UTC | #1
Quoting Laurent Pinchart (2024-06-16 17:39:01)
> agc_mean_luminance.h uses utils::Duration, include the corresponding
> header.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/libipa/agc_mean_luminance.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h
> index d1bddda5d162..576d28be8eb0 100644
> --- a/src/ipa/libipa/agc_mean_luminance.h
> +++ b/src/ipa/libipa/agc_mean_luminance.h
> @@ -12,6 +12,8 @@
>  #include <tuple>
>  #include <vector>
>  
> +#include <libcamera/base/utils.h>
> +
>  #include <libcamera/controls.h>
>  
>  #include "libcamera/internal/yaml_parser.h"
> -- 
> Regards,
> 
> Laurent Pinchart
>
Paul Elder June 17, 2024, 10:11 a.m. UTC | #2
On Sun, Jun 16, 2024 at 07:39:01PM +0300, Laurent Pinchart wrote:
> agc_mean_luminance.h uses utils::Duration, include the corresponding
> header.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/ipa/libipa/agc_mean_luminance.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h
> index d1bddda5d162..576d28be8eb0 100644
> --- a/src/ipa/libipa/agc_mean_luminance.h
> +++ b/src/ipa/libipa/agc_mean_luminance.h
> @@ -12,6 +12,8 @@
>  #include <tuple>
>  #include <vector>
>  
> +#include <libcamera/base/utils.h>
> +
>  #include <libcamera/controls.h>
>  
>  #include "libcamera/internal/yaml_parser.h"
Dan Scally June 17, 2024, 10:12 a.m. UTC | #3
Hi Laurent - thanks for the patch

On 16/06/2024 17:39, Laurent Pinchart wrote:
> agc_mean_luminance.h uses utils::Duration, include the corresponding
> header.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---


Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   src/ipa/libipa/agc_mean_luminance.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h
> index d1bddda5d162..576d28be8eb0 100644
> --- a/src/ipa/libipa/agc_mean_luminance.h
> +++ b/src/ipa/libipa/agc_mean_luminance.h
> @@ -12,6 +12,8 @@
>   #include <tuple>
>   #include <vector>
>   
> +#include <libcamera/base/utils.h>
> +
>   #include <libcamera/controls.h>
>   
>   #include "libcamera/internal/yaml_parser.h"

Patch
diff mbox series

diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h
index d1bddda5d162..576d28be8eb0 100644
--- a/src/ipa/libipa/agc_mean_luminance.h
+++ b/src/ipa/libipa/agc_mean_luminance.h
@@ -12,6 +12,8 @@ 
 #include <tuple>
 #include <vector>
 
+#include <libcamera/base/utils.h>
+
 #include <libcamera/controls.h>
 
 #include "libcamera/internal/yaml_parser.h"