[3/3] ipa: rkisp1: cproc: Drop incorrect [[maybe_unused]]

20287 diff mbox series

A few function parameters are marked with [[maybe_unused]] but are
actually used. Drop the attribute.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/cproc.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Quoting Stefan Klug (2024-06-13 09:33:20)
> A few function parameters are marked with [[maybe_unused]] but are
> actually used. Drop the attribute.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/rkisp1/algorithms/cproc.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp
> index 9f400a52dd96..ef0931b20453 100644
> --- a/src/ipa/rkisp1/algorithms/cproc.cpp
> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp
> @@ -54,7 +54,7 @@ int convertContrastOrSaturation(const float v)
>  /**
>   * \copydoc libcamera::ipa::Algorithm::init
>   */
> -int ColorProcessing::init([[maybe_unused]] IPAContext &context,
> +int ColorProcessing::init(IPAContext &context,
>                           [[maybe_unused]] const YamlObject &tuningData)
>  {
>         auto &cmap = context.ctrlMap;
> @@ -69,7 +69,7 @@ int ColorProcessing::init([[maybe_unused]] IPAContext &context,
>  /**
>   * \copydoc libcamera::ipa::Algorithm::configure
>   */
> -int ColorProcessing::configure([[maybe_unused]] IPAContext &context,
> +int ColorProcessing::configure(IPAContext &context,
>                                [[maybe_unused]] const IPACameraSensorInfo &configInfo)
>  {
>         auto &cproc = context.activeState.cproc;
> @@ -85,7 +85,7 @@ int ColorProcessing::configure([[maybe_unused]] IPAContext &context,
>   * \copydoc libcamera::ipa::Algorithm::queueRequest
>   */
>  void ColorProcessing::queueRequest(IPAContext &context,
> -                                  [[maybe_unused]] const uint32_t frame,
> +                                  const uint32_t frame,
>                                    IPAFrameContext &frameContext,
>                                    const ControlList &controls)
>  {
> -- 
> 2.43.0
>

Hi Stefan,

Thank you for the patch.

On Thu, Jun 13, 2024 at 10:33:20AM +0200, Stefan Klug wrote:
> A few function parameters are marked with [[maybe_unused]] but are
> actually used. Drop the attribute.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/rkisp1/algorithms/cproc.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp
> index 9f400a52dd96..ef0931b20453 100644
> --- a/src/ipa/rkisp1/algorithms/cproc.cpp
> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp
> @@ -54,7 +54,7 @@ int convertContrastOrSaturation(const float v)
>  /**
>   * \copydoc libcamera::ipa::Algorithm::init
>   */
> -int ColorProcessing::init([[maybe_unused]] IPAContext &context,
> +int ColorProcessing::init(IPAContext &context,
>  			  [[maybe_unused]] const YamlObject &tuningData)
>  {
>  	auto &cmap = context.ctrlMap;
> @@ -69,7 +69,7 @@ int ColorProcessing::init([[maybe_unused]] IPAContext &context,
>  /**
>   * \copydoc libcamera::ipa::Algorithm::configure
>   */
> -int ColorProcessing::configure([[maybe_unused]] IPAContext &context,
> +int ColorProcessing::configure(IPAContext &context,
>  			       [[maybe_unused]] const IPACameraSensorInfo &configInfo)
>  {
>  	auto &cproc = context.activeState.cproc;
> @@ -85,7 +85,7 @@ int ColorProcessing::configure([[maybe_unused]] IPAContext &context,
>   * \copydoc libcamera::ipa::Algorithm::queueRequest
>   */
>  void ColorProcessing::queueRequest(IPAContext &context,
> -				   [[maybe_unused]] const uint32_t frame,
> +				   const uint32_t frame,
>  				   IPAFrameContext &frameContext,
>  				   const ControlList &controls)
>  {
> -- 
> 2.43.0
>