[3/6] ipa: rkisp1: goc: Use copydoc
diff mbox series

Message ID 20240611212101.14313-4-laurent.pinchart@ideasonboard.com
State Accepted
Commit 1566e67f76e949edddc03a34971ed45bee1ab4a6
Headers show
Series
  • ipa: rksip1: goc: Assorted fixes
Related show

Commit Message

Laurent Pinchart June 11, 2024, 9:20 p.m. UTC
Use the Doygen \copydoc command instead of duplicating documentation.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/goc.cpp | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Stefan Klug June 12, 2024, 7:27 a.m. UTC | #1
Hi Laurent,

thanks you for the patch. Kieran mentioned the same on cproc and I
missed to backport it. Thanks for the fix.

On Wed, Jun 12, 2024 at 12:20:58AM +0300, Laurent Pinchart wrote:
> Use the Doygen \copydoc command instead of duplicating documentation.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> 

Cheers,
Stefan

> ---
>  src/ipa/rkisp1/algorithms/goc.cpp | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp
> index 01331b653c27..65460eb45135 100644
> --- a/src/ipa/rkisp1/algorithms/goc.cpp
> +++ b/src/ipa/rkisp1/algorithms/goc.cpp
> @@ -64,11 +64,7 @@ int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData)
>  }
>  
>  /**
> - * \brief Configure the Gamma given a configInfo
> - * \param[in] context The shared IPA context
> - * \param[in] configInfo The IPA configuration data
> - *
> - * \return 0
> + * \copydoc libcamera::ipa::Algorithm::configure
>   */
>  int GammaOutCorrection::configure(IPAContext &context,
>  				  [[maybe_unused]] const IPACameraSensorInfo &configInfo)
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series

diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp
index 01331b653c27..65460eb45135 100644
--- a/src/ipa/rkisp1/algorithms/goc.cpp
+++ b/src/ipa/rkisp1/algorithms/goc.cpp
@@ -64,11 +64,7 @@  int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData)
 }
 
 /**
- * \brief Configure the Gamma given a configInfo
- * \param[in] context The shared IPA context
- * \param[in] configInfo The IPA configuration data
- *
- * \return 0
+ * \copydoc libcamera::ipa::Algorithm::configure
  */
 int GammaOutCorrection::configure(IPAContext &context,
 				  [[maybe_unused]] const IPACameraSensorInfo &configInfo)