| Message ID | 20240611212101.14313-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 2a253be3339d70f92c8e3d63ea19bafafc628219 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, thanks you for the patch. You are absolutely right... On Wed, Jun 12, 2024 at 12:20:57AM +0300, Laurent Pinchart wrote: > A few function parameters are marked with [[maybe_unused]] but are > actually used. Drop the attribute. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> Cheers, Stefan > --- > src/ipa/rkisp1/algorithms/goc.cpp | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp > index fc5ad9f9177e..01331b653c27 100644 > --- a/src/ipa/rkisp1/algorithms/goc.cpp > +++ b/src/ipa/rkisp1/algorithms/goc.cpp > @@ -48,8 +48,7 @@ const float kDefaultGamma = 2.2f; > /** > * \copydoc libcamera::ipa::Algorithm::init > */ > -int GammaOutCorrection::init([[maybe_unused]] IPAContext &context, > - [[maybe_unused]] const YamlObject &tuningData) > +int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData) > { > if (context.hw->numGammaOutSamples != > RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10) { > @@ -81,8 +80,7 @@ int GammaOutCorrection::configure(IPAContext &context, > /** > * \copydoc libcamera::ipa::Algorithm::queueRequest > */ > -void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, > - [[maybe_unused]] const uint32_t frame, > +void GammaOutCorrection::queueRequest(IPAContext &context, const uint32_t frame, > IPAFrameContext &frameContext, > const ControlList &controls) > { > @@ -102,9 +100,9 @@ void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, > /** > * \copydoc libcamera::ipa::Algorithm::prepare > */ > -void GammaOutCorrection::prepare([[maybe_unused]] IPAContext &context, > +void GammaOutCorrection::prepare(IPAContext &context, > [[maybe_unused]] const uint32_t frame, > - [[maybe_unused]] IPAFrameContext &frameContext, > + IPAFrameContext &frameContext, > rkisp1_params_cfg *params) > { > ASSERT(context.hw->numGammaOutSamples == > -- > Regards, > > Laurent Pinchart >
diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp index fc5ad9f9177e..01331b653c27 100644 --- a/src/ipa/rkisp1/algorithms/goc.cpp +++ b/src/ipa/rkisp1/algorithms/goc.cpp @@ -48,8 +48,7 @@ const float kDefaultGamma = 2.2f; /** * \copydoc libcamera::ipa::Algorithm::init */ -int GammaOutCorrection::init([[maybe_unused]] IPAContext &context, - [[maybe_unused]] const YamlObject &tuningData) +int GammaOutCorrection::init(IPAContext &context, const YamlObject &tuningData) { if (context.hw->numGammaOutSamples != RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10) { @@ -81,8 +80,7 @@ int GammaOutCorrection::configure(IPAContext &context, /** * \copydoc libcamera::ipa::Algorithm::queueRequest */ -void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, - [[maybe_unused]] const uint32_t frame, +void GammaOutCorrection::queueRequest(IPAContext &context, const uint32_t frame, IPAFrameContext &frameContext, const ControlList &controls) { @@ -102,9 +100,9 @@ void GammaOutCorrection::queueRequest([[maybe_unused]] IPAContext &context, /** * \copydoc libcamera::ipa::Algorithm::prepare */ -void GammaOutCorrection::prepare([[maybe_unused]] IPAContext &context, +void GammaOutCorrection::prepare(IPAContext &context, [[maybe_unused]] const uint32_t frame, - [[maybe_unused]] IPAFrameContext &frameContext, + IPAFrameContext &frameContext, rkisp1_params_cfg *params) { ASSERT(context.hw->numGammaOutSamples ==
A few function parameters are marked with [[maybe_unused]] but are actually used. Drop the attribute. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/rkisp1/algorithms/goc.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)