[2/2] libcamera: software_isp: Fix includes ordering in simple.cpp
diff mbox series

Message ID 20240610180855.1643125-3-mzamazal@redhat.com
State Accepted
Headers show
Series
  • Includes ordering fix
Related show

Commit Message

Milan Zamazal June 10, 2024, 6:08 p.m. UTC
Let's make it conforming to the defined clang-format.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/libcamera/pipeline/simple/simple.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Laurent Pinchart June 10, 2024, 6:57 p.m. UTC | #1
Hi Milan,

Thank you for the patch.

On Mon, Jun 10, 2024 at 08:08:50PM +0200, Milan Zamazal wrote:
> Let's make it conforming to the defined clang-format.
> 
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index db3575c3..eb36578e 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -13,8 +13,8 @@
>  #include <memory>
>  #include <queue>
>  #include <set>
> -#include <string>
>  #include <string.h>
> +#include <string>
>  #include <unordered_map>
>  #include <utility>
>  #include <vector>
> @@ -38,7 +38,6 @@
>  #include "libcamera/internal/v4l2_subdevice.h"
>  #include "libcamera/internal/v4l2_videodevice.h"
>  
> -
>  namespace libcamera {
>  
>  LOG_DEFINE_CATEGORY(SimplePipeline)
Kieran Bingham June 11, 2024, 12:03 p.m. UTC | #2
Quoting Milan Zamazal (2024-06-10 19:08:50)
> Let's make it conforming to the defined clang-format.
> 

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> ---
>  src/libcamera/pipeline/simple/simple.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index db3575c3..eb36578e 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -13,8 +13,8 @@
>  #include <memory>
>  #include <queue>
>  #include <set>
> -#include <string>
>  #include <string.h>
> +#include <string>
>  #include <unordered_map>
>  #include <utility>
>  #include <vector>
> @@ -38,7 +38,6 @@
>  #include "libcamera/internal/v4l2_subdevice.h"
>  #include "libcamera/internal/v4l2_videodevice.h"
>  
> -
>  namespace libcamera {
>  
>  LOG_DEFINE_CATEGORY(SimplePipeline)
> -- 
> 2.44.1
>

Patch
diff mbox series

diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
index db3575c3..eb36578e 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -13,8 +13,8 @@ 
 #include <memory>
 #include <queue>
 #include <set>
-#include <string>
 #include <string.h>
+#include <string>
 #include <unordered_map>
 #include <utility>
 #include <vector>
@@ -38,7 +38,6 @@ 
 #include "libcamera/internal/v4l2_subdevice.h"
 #include "libcamera/internal/v4l2_videodevice.h"
 
-
 namespace libcamera {
 
 LOG_DEFINE_CATEGORY(SimplePipeline)