[libcamera-devel,16/21] ipa: Remove IPAInterface::init()
diff mbox series

Message ID 20190924172503.30864-17-jacopo@jmondi.org
State Superseded
Headers show
Series
  • Implement control serialization
Related show

Commit Message

Jacopo Mondi Sept. 24, 2019, 5:24 p.m. UTC 
From: Niklas Söderlund <niklas.soderlund@ragnatech.se>

The function performs no useful task and will not be needed when we
extend the IPA interface to process parameter and statistic buffers.

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
[jacopo: Remove init() method in ipa_proxy_linux.cpp]
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 include/ipa/ipa_interface.h             |  2 --
 src/ipa/ipa_dummy.cpp                   | 10 ----------
 src/libcamera/ipa_interface.cpp         |  5 -----
 src/libcamera/pipeline/vimc.cpp         |  2 --
 src/libcamera/proxy/ipa_proxy_linux.cpp |  9 ---------
 5 files changed, 28 deletions(-)

Patch
diff mbox series 

diff --git a/include/ipa/ipa_interface.h b/include/ipa/ipa_interface.h
index 2c5eb1fd5243..9bbc4cf58ec6 100644
--- a/include/ipa/ipa_interface.h
+++ b/include/ipa/ipa_interface.h
@@ -13,8 +13,6 @@  class IPAInterface
 {
 public:
 	virtual ~IPAInterface() {}
-
-	virtual int init() = 0;
 };
 
 } /* namespace libcamera */
diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp
index 9d0cbdc8b1ad..c833e5fb0b2d 100644
--- a/src/ipa/ipa_dummy.cpp
+++ b/src/ipa/ipa_dummy.cpp
@@ -5,8 +5,6 @@ 
  * ipa_dummy.cpp - Dummy Image Processing Algorithm module
  */
 
-#include <iostream>
-
 #include <ipa/ipa_interface.h>
 #include <ipa/ipa_module_info.h>
 
@@ -14,16 +12,8 @@  namespace libcamera {
 
 class IPADummy : public IPAInterface
 {
-public:
-	int init();
 };
 
-int IPADummy::init()
-{
-	std::cout << "initializing dummy IPA!" << std::endl;
-	return 0;
-}
-
 /*
  * External IPA module interface
  */
diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp
index d7d8ca8881ef..f70d91ded1ab 100644
--- a/src/libcamera/ipa_interface.cpp
+++ b/src/libcamera/ipa_interface.cpp
@@ -19,9 +19,4 @@  namespace libcamera {
  * \brief Interface for IPA implementation
  */
 
-/**
- * \fn IPAInterface::init()
- * \brief Initialise the IPAInterface
- */
-
 } /* namespace libcamera */
diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp
index 80a71f7cd5fd..499ce59181c5 100644
--- a/src/libcamera/pipeline/vimc.cpp
+++ b/src/libcamera/pipeline/vimc.cpp
@@ -364,8 +364,6 @@  bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)
 	ipa_ = IPAManager::instance()->createIPA(this, 0, 0);
 	if (ipa_ == nullptr)
 		LOG(VIMC, Warning) << "no matching IPA found";
-	else
-		ipa_->init();
 
 	std::unique_ptr<VimcCameraData> data = utils::make_unique<VimcCameraData>(this);
 
diff --git a/src/libcamera/proxy/ipa_proxy_linux.cpp b/src/libcamera/proxy/ipa_proxy_linux.cpp
index 62fcb529e1c7..c9eaedff0224 100644
--- a/src/libcamera/proxy/ipa_proxy_linux.cpp
+++ b/src/libcamera/proxy/ipa_proxy_linux.cpp
@@ -26,8 +26,6 @@  public:
 	IPAProxyLinux(IPAModule *ipam);
 	~IPAProxyLinux();
 
-	int init();
-
 private:
 	void readyRead(IPCUnixSocket *ipc);
 
@@ -36,13 +34,6 @@  private:
 	IPCUnixSocket *socket_;
 };
 
-int IPAProxyLinux::init()
-{
-	LOG(IPAProxy, Debug) << "initializing IPA via dummy proxy!";
-
-	return 0;
-}
-
 IPAProxyLinux::IPAProxyLinux(IPAModule *ipam)
 	: proc_(nullptr), socket_(nullptr)
 {