[v3,1/5] libcamera: software_isp: Use a specific integer type for black level
diff mbox series

Message ID 20240523112656.559150-2-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Software ISP levels cleanup
Related show

Commit Message

Milan Zamazal May 23, 2024, 11:26 a.m. UTC 
The documented range of values corresponds to uint8_t, so let's use that
type.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Andrei Konovalov <andrey.konovalov.ynk@gmail.com>
---
 src/ipa/simple/black_level.cpp | 2 +-
 src/ipa/simple/black_level.h   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp
index 53b4c040..cc490eb5 100644
--- a/src/ipa/simple/black_level.cpp
+++ b/src/ipa/simple/black_level.cpp
@@ -43,7 +43,7 @@  BlackLevel::BlackLevel()
  * \return The black level, in the range from 0 (minimum) to 255 (maximum).
  * If the black level couldn't be determined yet, return 0.
  */
-unsigned int BlackLevel::get() const
+uint8_t BlackLevel::get() const
 {
 	return blackLevelSet_ ? blackLevel_ : 0;
 }
diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h
index 25094217..5e032f9f 100644
--- a/src/ipa/simple/black_level.h
+++ b/src/ipa/simple/black_level.h
@@ -8,6 +8,7 @@ 
 #pragma once
 
 #include <array>
+#include <stdint.h>
 
 #include "libcamera/internal/software_isp/swisp_stats.h"
 
@@ -17,11 +18,11 @@  class BlackLevel
 {
 public:
 	BlackLevel();
-	unsigned int get() const;
+	uint8_t get() const;
 	void update(SwIspStats::Histogram &yHistogram);
 
 private:
-	unsigned int blackLevel_;
+	uint8_t blackLevel_;
 	bool blackLevelSet_;
 };