[v3,7/7] ipa: rpi: Add accessor function for monoSensor_
diff mbox series

Message ID 20240510100208.12188-8-naush@raspberrypi.com
State Accepted
Commit 2031e2f2901403242329d7b59d97fa7c98758206
Headers show
Series
  • Pre Raspberry Pi 5 support changes
Related show

Commit Message

Naushir Patuck May 10, 2024, 10:02 a.m. UTC
The monoSensor_ member variable will be used by the derived IPAs in an
upcoming commit, so add an accessor function for it.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/ipa/rpi/common/ipa_base.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Kieran Bingham May 10, 2024, 11:30 a.m. UTC | #1
Quoting Naushir Patuck (2024-05-10 11:02:08)
> The monoSensor_ member variable will be used by the derived IPAs in an
> upcoming commit, so add an accessor function for it.
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/rpi/common/ipa_base.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
> index 074b304e9fd8..a95cda1ffe51 100644
> --- a/src/ipa/rpi/common/ipa_base.h
> +++ b/src/ipa/rpi/common/ipa_base.h
> @@ -49,6 +49,11 @@ public:
>         void processStats(const ProcessParams &params) override;
>  
>  protected:
> +       bool monoSensor()
> +       {
> +               return monoSensor_;
> +       }
> +
>         /* Raspberry Pi controller specific defines. */
>         std::unique_ptr<RPiController::CamHelper> helper_;
>         RPiController::Controller controller_;
> -- 
> 2.34.1
>
Jacopo Mondi May 15, 2024, 12:15 p.m. UTC | #2
Hi Naushir

On Fri, May 10, 2024 at 11:02:08AM GMT, Naushir Patuck wrote:
> The monoSensor_ member variable will be used by the derived IPAs in an
> upcoming commit, so add an accessor function for it.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> ---
>  src/ipa/rpi/common/ipa_base.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
> index 074b304e9fd8..a95cda1ffe51 100644
> --- a/src/ipa/rpi/common/ipa_base.h
> +++ b/src/ipa/rpi/common/ipa_base.h
> @@ -49,6 +49,11 @@ public:
>  	void processStats(const ProcessParams &params) override;
>
>  protected:
> +	bool monoSensor()

        bool monoSensor() const

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> +	{
> +		return monoSensor_;
> +	}
> +
>  	/* Raspberry Pi controller specific defines. */
>  	std::unique_ptr<RPiController::CamHelper> helper_;
>  	RPiController::Controller controller_;
> --
> 2.34.1
>

Patch
diff mbox series

diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
index 074b304e9fd8..a95cda1ffe51 100644
--- a/src/ipa/rpi/common/ipa_base.h
+++ b/src/ipa/rpi/common/ipa_base.h
@@ -49,6 +49,11 @@  public:
 	void processStats(const ProcessParams &params) override;
 
 protected:
+	bool monoSensor()
+	{
+		return monoSensor_;
+	}
+
 	/* Raspberry Pi controller specific defines. */
 	std::unique_ptr<RPiController::CamHelper> helper_;
 	RPiController::Controller controller_;