ipa: libipa: camera_sensor_helper: Remove stray semicolon
diff mbox series

Message ID 20240508145149.1453199-1-paul.elder@ideasonboard.com
State Not Applicable
Headers show
Series
  • ipa: libipa: camera_sensor_helper: Remove stray semicolon
Related show

Commit Message

Paul Elder May 8, 2024, 2:51 p.m. UTC
Remove a stray semicolon that was apparently causing compilation
problems on clang 17.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart May 8, 2024, 3:28 p.m. UTC | #1
On Wed, May 08, 2024 at 11:51:49PM +0900, Paul Elder wrote:
> Remove a stray semicolon that was apparently causing compilation
> problems on clang 17.
> 
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
>  src/ipa/libipa/camera_sensor_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h
> index dcdbe82b..72024afc 100644
> --- a/src/ipa/libipa/camera_sensor_helper.h
> +++ b/src/ipa/libipa/camera_sensor_helper.h
> @@ -68,7 +68,7 @@ public:
>  
>  	static std::vector<CameraSensorHelperFactoryBase *> &factories();
>  
> -	const std::string &name() const { return name_; };
> +	const std::string &name() const { return name_; }

I think you're not basing this patch on upstream libcamera.

>  
>  private:
>  	LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)

Patch
diff mbox series

diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h
index dcdbe82b..72024afc 100644
--- a/src/ipa/libipa/camera_sensor_helper.h
+++ b/src/ipa/libipa/camera_sensor_helper.h
@@ -68,7 +68,7 @@  public:
 
 	static std::vector<CameraSensorHelperFactoryBase *> &factories();
 
-	const std::string &name() const { return name_; };
+	const std::string &name() const { return name_; }
 
 private:
 	LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)