[2/2] fixup! ipa: ipu3: Remove bespoke AGC functions from IPU3
diff mbox series

Message ID 20240508115351.4183582-1-kieran.bingham@ideasonboard.com
State Superseded
Headers show
Series
  • [1/2] fixup! ipa: libipa: Add AgcMeanLuminance base class
Related show

Commit Message

Kieran Bingham May 8, 2024, 11:53 a.m. UTC 
I will apply the series with the following fixup.

Fixes:
FAILED: src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o 
clang++ -Isrc/ipa/ipu3/ipa_ipu3.so.p -Isrc/ipa/ipu3 -I../src/ipa/ipu3 -Iinclude -I../include -Isrc/ipa -I../src/ipa -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O0 -g -stdlib=libc++ -Wextra-semi -Wthread-safety -Wshadow -include /builds/camera/libcamera/build/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o -MF src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o.d -o src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o -c ../src/ipa/ipu3/algorithms/agc.cpp
../src/ipa/ipu3/algorithms/agc.cpp:60:25: error: unused variable 'kEvGainTarget' [-Werror,-Wunused-const-variable]
static constexpr double kEvGainTarget = 0.5;
                        ^
../src/ipa/ipu3/algorithms/agc.cpp:63:27: error: unused variable 'kNumStartupFrames' [-Werror,-Wunused-const-variable]
static constexpr uint32_t kNumStartupFrames = 10;
                          ^
../src/ipa/ipu3/algorithms/agc.cpp:71:25: error: unused variable 'kRelativeLuminanceTarget' [-Werror,-Wunused-const-variable]
static constexpr double kRelativeLuminanceTarget = 0.16;
                        ^
3 errors generated.


Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/ipa/ipu3/algorithms/agc.cpp | 14 --------------
 1 file changed, 14 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp
index e1bca07f7646..c9b5548c4548 100644
--- a/src/ipa/ipu3/algorithms/agc.cpp
+++ b/src/ipa/ipu3/algorithms/agc.cpp
@@ -56,20 +56,6 @@  static constexpr utils::Duration kMaxShutterSpeed = 60ms;
 /* Histogram constants */
 static constexpr uint32_t knumHistogramBins = 256;
 
-/* Target value to reach for the top 2% of the histogram */
-static constexpr double kEvGainTarget = 0.5;
-
-/* Number of frames to wait before calculating stats on minimum exposure */
-static constexpr uint32_t kNumStartupFrames = 10;
-
-/*
- * Relative luminance target.
- *
- * It's a number that's chosen so that, when the camera points at a grey
- * target, the resulting image brightness is considered right.
- */
-static constexpr double kRelativeLuminanceTarget = 0.16;
-
 Agc::Agc()
 	: minShutterSpeed_(0s), maxShutterSpeed_(0s)
 {