v4l2: meson: Keep defines sorted alphabetically
diff mbox series

Message ID 20240327132015.22095-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 48f3a25d7c5f6f4b2eef590c79d8eeaef32014d2
Headers show
Series
  • v4l2: meson: Keep defines sorted alphabetically
Related show

Commit Message

Laurent Pinchart March 27, 2024, 1:20 p.m. UTC 
Due to my mistake, commit 705601781b6a ("v4l2: Unset _TIME_BITS in
addition to _FILE_OFFSET_BITS") got merged with incorrect sorting of
defines. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/v4l2/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 705601781b6ab4f3035719ddaf1e442f4a5e8737

Comments

Umang Jain March 27, 2024, 1:22 p.m. UTC | #1 
Hi Laurent,

Thanks for the patch

On 27/03/24 6:50 pm, Laurent Pinchart wrote:
> Due to my mistake, commit 705601781b6a ("v4l2: Unset _TIME_BITS in
> addition to _FILE_OFFSET_BITS") got merged with incorrect sorting of
> defines. Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   src/v4l2/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build
> index 12d1e2a4c3c0..58f53bf3d0f4 100644
> --- a/src/v4l2/meson.build
> +++ b/src/v4l2/meson.build
> @@ -23,8 +23,8 @@ v4l2_compat_cpp_args = [
>       # file operations, disable transparent large file support.
>       '-U_FILE_OFFSET_BITS',
>       '-D_FILE_OFFSET_BITS=32',
> -    '-U_TIME_BITS',
>       '-D_LARGEFILE64_SOURCE',
> +    '-U_TIME_BITS',
>       '-fvisibility=hidden',
>   ]
>   
>
> base-commit: 705601781b6ab4f3035719ddaf1e442f4a5e8737
Dan Scally March 27, 2024, 9:17 p.m. UTC | #2 
Hi Laurent

On 27/03/2024 13:20, Laurent Pinchart wrote:
> Due to my mistake, commit 705601781b6a ("v4l2: Unset _TIME_BITS in
> addition to _FILE_OFFSET_BITS") got merged with incorrect sorting of
> defines. Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

> ---
>   src/v4l2/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build
> index 12d1e2a4c3c0..58f53bf3d0f4 100644
> --- a/src/v4l2/meson.build
> +++ b/src/v4l2/meson.build
> @@ -23,8 +23,8 @@ v4l2_compat_cpp_args = [
>       # file operations, disable transparent large file support.
>       '-U_FILE_OFFSET_BITS',
>       '-D_FILE_OFFSET_BITS=32',
> -    '-U_TIME_BITS',
>       '-D_LARGEFILE64_SOURCE',
> +    '-U_TIME_BITS',
>       '-fvisibility=hidden',
>   ]
>   
>
> base-commit: 705601781b6ab4f3035719ddaf1e442f4a5e8737

Patch
diff mbox series 

diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build
index 12d1e2a4c3c0..58f53bf3d0f4 100644
--- a/src/v4l2/meson.build
+++ b/src/v4l2/meson.build
@@ -23,8 +23,8 @@  v4l2_compat_cpp_args = [
     # file operations, disable transparent large file support.
     '-U_FILE_OFFSET_BITS',
     '-D_FILE_OFFSET_BITS=32',
-    '-U_TIME_BITS',
     '-D_LARGEFILE64_SOURCE',
+    '-U_TIME_BITS',
     '-fvisibility=hidden',
 ]