| Message ID | 20190916201435.29329-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | bd67bef8c67dac9759ef3634121062a934651fa3 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On Mon, Sep 16, 2019 at 11:14:35PM +0300, Laurent Pinchart wrote: > Our coding style don't indent namespace contents. Update .clang-format > accordingly. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .clang-format | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.clang-format b/.clang-format > index 7c5f7b00b3ee..0f4d2b52e848 100644 > --- a/.clang-format > +++ b/.clang-format > @@ -80,7 +80,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false > MacroBlockBegin: '' > MacroBlockEnd: '' > MaxEmptyLinesToKeep: 1 > -NamespaceIndentation: Inner > +NamespaceIndentation: None > #ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0 > ObjCBlockIndentWidth: 8 > ObjCSpaceAfterProperty: true Nice Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Laurent, Thanks for your work. On 2019-09-16 23:14:35 +0300, Laurent Pinchart wrote: > Our coding style don't indent namespace contents. Update .clang-format > accordingly. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > .clang-format | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.clang-format b/.clang-format > index 7c5f7b00b3ee..0f4d2b52e848 100644 > --- a/.clang-format > +++ b/.clang-format > @@ -80,7 +80,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false > MacroBlockBegin: '' > MacroBlockEnd: '' > MaxEmptyLinesToKeep: 1 > -NamespaceIndentation: Inner > +NamespaceIndentation: None > #ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0 > ObjCBlockIndentWidth: 8 > ObjCSpaceAfterProperty: true > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Laurent, On 17/09/2019 10:38, Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your work. > > On 2019-09-16 23:14:35 +0300, Laurent Pinchart wrote: >> Our coding style don't indent namespace contents. Update .clang-format s/don't/doesn't/ >> accordingly. >> >> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> This one gets an extra \o/ ! \o/-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > >> --- >> .clang-format | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.clang-format b/.clang-format >> index 7c5f7b00b3ee..0f4d2b52e848 100644 >> --- a/.clang-format >> +++ b/.clang-format >> @@ -80,7 +80,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false >> MacroBlockBegin: '' >> MacroBlockEnd: '' >> MaxEmptyLinesToKeep: 1 >> -NamespaceIndentation: Inner >> +NamespaceIndentation: None >> #ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0 >> ObjCBlockIndentWidth: 8 >> ObjCSpaceAfterProperty: true >> -- >> Regards, >> >> Laurent Pinchart >> >> _______________________________________________ >> libcamera-devel mailing list >> libcamera-devel@lists.libcamera.org >> https://lists.libcamera.org/listinfo/libcamera-devel >
diff --git a/.clang-format b/.clang-format index 7c5f7b00b3ee..0f4d2b52e848 100644 --- a/.clang-format +++ b/.clang-format @@ -80,7 +80,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false MacroBlockBegin: '' MacroBlockEnd: '' MaxEmptyLinesToKeep: 1 -NamespaceIndentation: Inner +NamespaceIndentation: None #ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0 ObjCBlockIndentWidth: 8 ObjCSpaceAfterProperty: true
Our coding style don't indent namespace contents. Update .clang-format accordingly. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .clang-format | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)