utils: checkstyle.py: Fix known_trailers sort order
diff mbox series

Message ID 20240311132451.182317-1-kieran.bingham@ideasonboard.com
State Superseded
Headers show
Series
  • utils: checkstyle.py: Fix known_trailers sort order
Related show

Commit Message

Kieran Bingham March 11, 2024, 1:24 p.m. UTC 
From: Hans de Goede <hdegoede@redhat.com>

An unruly libcamera maintainer merged the wrong patch adding the
Co-developed-by: tag to the known_trailers.

Fix the sort order alphabetically to match the version which should have
been merged.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 utils/checkstyle.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Kieran Bingham March 11, 2024, 2:23 p.m. UTC | #1 
Quoting Kieran Bingham (2024-03-11 13:24:51)
> From: Hans de Goede <hdegoede@redhat.com>
> 
> An unruly libcamera maintainer merged the wrong patch adding the
> Co-developed-by: tag to the known_trailers.
> 
> Fix the sort order alphabetically to match the version which should have
> been merged.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  utils/checkstyle.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
> index 52cf770c9da3..c0a8bdfe10d5 100755
> --- a/utils/checkstyle.py
> +++ b/utils/checkstyle.py
> @@ -471,6 +471,7 @@ class TrailersChecker(CommitChecker):
>      known_trailers = {
>          'Acked-by': email_regex,
>          'Bug': link_regex,
> +        'Co-developed-by': email_regex,
>          'Fixes': commit_regex,
>          'Link': link_regex,
>          'Reported-by': validate_reported_by,

That same unruly maintainer can't create a fixup correctly either!

He failed to add the removal of the incorrect line :-(

--
Kieran


> -- 
> 2.34.1
>

Patch
diff mbox series 

diff --git a/utils/checkstyle.py b/utils/checkstyle.py
index 52cf770c9da3..c0a8bdfe10d5 100755
--- a/utils/checkstyle.py
+++ b/utils/checkstyle.py
@@ -471,6 +471,7 @@  class TrailersChecker(CommitChecker):
     known_trailers = {
         'Acked-by': email_regex,
         'Bug': link_regex,
+        'Co-developed-by': email_regex,
         'Fixes': commit_regex,
         'Link': link_regex,
         'Reported-by': validate_reported_by,