[v2,2/2] meson_options: Autodetect pycamera support
diff mbox series

Message ID 20240223174718.198950-3-kieran.bingham@ideasonboard.com
State Accepted
Commit 4d122bfbb7018dfd1ffe8fca5f6d0a716d7a5fa6
Headers show
Series
  • pycamera: Fix enablement
Related show

Commit Message

Kieran Bingham Feb. 23, 2024, 5:47 p.m. UTC
The pycamera was defaulted to be disabled due to a requirement
on a specialised branch of the pybind dependency.

This requirement on a subproject has been removed and we can
now build the pycamera component provided that the distribution
packages pybind directly which is common.

Enable the pycamera build option to be selected automatically
when both Python and pybind are detected on the system.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 meson_options.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Feb. 23, 2024, 8:42 p.m. UTC | #1
Hi Kieran,

Thank you for the patch.

On Fri, Feb 23, 2024 at 05:47:18PM +0000, Kieran Bingham wrote:
> The pycamera was defaulted to be disabled due to a requirement
> on a specialised branch of the pybind dependency.
> 
> This requirement on a subproject has been removed and we can
> now build the pycamera component provided that the distribution
> packages pybind directly which is common.
> 
> Enable the pycamera build option to be selected automatically
> when both Python and pybind are detected on the system.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  meson_options.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson_options.txt b/meson_options.txt
> index 5fdc7be87a54..99dab96d7b21 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -53,7 +53,7 @@ option('pipelines',
>  
>  option('pycamera',
>          type : 'feature',
> -        value : 'disabled',
> +        value : 'auto',
>          description : 'Enable libcamera Python bindings (experimental)')
>  
>  option('qcam',

Patch
diff mbox series

diff --git a/meson_options.txt b/meson_options.txt
index 5fdc7be87a54..99dab96d7b21 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -53,7 +53,7 @@  option('pipelines',
 
 option('pycamera',
         type : 'feature',
-        value : 'disabled',
+        value : 'auto',
         description : 'Enable libcamera Python bindings (experimental)')
 
 option('qcam',