doc: gstreamer: Add missing queues
diff mbox series

Message ID 20240202090805.120601-1-nicolas@ndufresne.ca
State Accepted
Headers show
Series
  • doc: gstreamer: Add missing queues
Related show

Commit Message

Nicolas Dufresne Feb. 2, 2024, 9:08 a.m. UTC 
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>

As libcamerasrc reports some latency, a queue is needed in order to store the
data in case the buffers has been produced slightly ahead of our reported
latency.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
 README.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Laurent Pinchart Feb. 2, 2024, 9:24 a.m. UTC | #1 
Hi Nicolas,

Thank you for the patch.

On Fri, Feb 02, 2024 at 10:08:05AM +0100, Nicolas Dufresne wrote:
> From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> 
> As libcamerasrc reports some latency, a queue is needed in order to store the
> data in case the buffers has been produced slightly ahead of our reported
> latency.

I fully trust your expertise on this :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
>  README.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 6b764fb7..cc39cd5f 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -134,7 +134,7 @@ onto the OpenGL accelerated display element on your system.
>  
>  .. code::
>  
> -  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! glimagesink
> +  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! queue ! glimagesink
>  
>  To show the first camera found you can omit the camera-name property, or you
>  can list the cameras and their capabilities using:
> @@ -149,7 +149,7 @@ if desired with a pipeline such as:
>  .. code::
>  
>    gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \
> -        glimagesink
> +                 queue ! glimagesink
>  
>  The libcamerasrc element has two log categories, named libcamera-provider (for
>  the video device provider) and libcamerasrc (for the operation of the camera).
> @@ -165,7 +165,7 @@ the following example could be used as a starting point:
>  
>     gst-launch-1.0 libcamerasrc ! \
>          video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \
> -        jpegenc ! multipartmux ! \
> +        queue ! jpegenc ! multipartmux ! \
>          tcpserversink host=0.0.0.0 port=5000
>  
>  Which can be received on another device over the network with:

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index 6b764fb7..cc39cd5f 100644
--- a/README.rst
+++ b/README.rst
@@ -134,7 +134,7 @@  onto the OpenGL accelerated display element on your system.
 
 .. code::
 
-  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! glimagesink
+  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! queue ! glimagesink
 
 To show the first camera found you can omit the camera-name property, or you
 can list the cameras and their capabilities using:
@@ -149,7 +149,7 @@  if desired with a pipeline such as:
 .. code::
 
   gst-launch-1.0 libcamerasrc ! 'video/x-raw,width=1280,height=720' ! \
-        glimagesink
+                 queue ! glimagesink
 
 The libcamerasrc element has two log categories, named libcamera-provider (for
 the video device provider) and libcamerasrc (for the operation of the camera).
@@ -165,7 +165,7 @@  the following example could be used as a starting point:
 
    gst-launch-1.0 libcamerasrc ! \
         video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \
-        jpegenc ! multipartmux ! \
+        queue ! jpegenc ! multipartmux ! \
         tcpserversink host=0.0.0.0 port=5000
 
 Which can be received on another device over the network with: