[libcamera-devel,v3,3/4] libipa: camera_sensor_helper: Add OV64A40 helper
diff mbox series

Message ID 20231206114307.94241-3-jacopo.mondi@ideasonboard.com
State Accepted
Headers show
Series
  • ipa: Add support for Arducam OV64A40
Related show

Commit Message

Jacopo Mondi Dec. 6, 2023, 11:43 a.m. UTC 
Add a CameraSensorHelper for the OV64A40 camera sensor.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Kieran Bingham Dec. 30, 2023, 9:44 p.m. UTC | #1 
Quoting Jacopo Mondi (2023-12-06 11:43:06)
> Add a CameraSensorHelper for the OV64A40 camera sensor.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index f0ecc3830115..ce29f423e712 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -547,6 +547,17 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("ov5693", CameraSensorHelperOv5693)
>  
> +class CameraSensorHelperOv64a40 : public CameraSensorHelper
> +{
> +public:
> +       CameraSensorHelperOv64a40()
> +       {
> +               gainType_ = AnalogueGainLinear;
> +               gainConstants_.linear = { 1, 0, 0, 128 };

Looks to match the Raspberry Pi equivalent implementation to me.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> +       }
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("ov64a40", CameraSensorHelperOv64a40)
> +
>  class CameraSensorHelperOv8858 : public CameraSensorHelper
>  {
>  public:
> -- 
> 2.41.0
>

Patch
diff mbox series 

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index f0ecc3830115..ce29f423e712 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -547,6 +547,17 @@  public:
 };
 REGISTER_CAMERA_SENSOR_HELPER("ov5693", CameraSensorHelperOv5693)
 
+class CameraSensorHelperOv64a40 : public CameraSensorHelper
+{
+public:
+	CameraSensorHelperOv64a40()
+	{
+		gainType_ = AnalogueGainLinear;
+		gainConstants_.linear = { 1, 0, 0, 128 };
+	}
+};
+REGISTER_CAMERA_SENSOR_HELPER("ov64a40", CameraSensorHelperOv64a40)
+
 class CameraSensorHelperOv8858 : public CameraSensorHelper
 {
 public: