[libcamera-devel] README.rst: Add missing libgtest-dev dependency for lc-compliance
diff mbox series

Message ID 20231205144544.26173-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 1c56d2a2cd2dcca86272675e21bbb1770d32db1f
Headers show
Series
  • [libcamera-devel] README.rst: Add missing libgtest-dev dependency for lc-compliance
Related show

Commit Message

Laurent Pinchart Dec. 5, 2023, 2:45 p.m. UTC 
lc-compliance requires gtest. When not available on the system, we
install it using a meson wrap, but it is still better to install the
system package. Add it as a dependency in README.rst.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 9d08a134c4195ad98dd09c5a9e2558a5765762f7

Comments

Jacopo Mondi Dec. 7, 2023, 5:04 p.m. UTC | #1 
Hi Laurent

On Tue, Dec 05, 2023 at 04:45:44PM +0200, Laurent Pinchart via libcamera-devel wrote:
> lc-compliance requires gtest. When not available on the system, we
> install it using a meson wrap, but it is still better to install the
> system package. Add it as a dependency in README.rst.

indeed

>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.rst b/README.rst
> index 4cb996375a9a..ac89d376ad18 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -97,7 +97,7 @@ for android: [optional]
>          libexif-dev libjpeg-dev
>
>  for lc-compliance: [optional]
> -        libevent-dev
> +        libevent-dev libgtest-dev
>
>  for abi-compat.sh: [optional]
>          abi-compliance-checker
>
> base-commit: 9d08a134c4195ad98dd09c5a9e2558a5765762f7
> --
> Regards,
>
> Laurent Pinchart
>
Kieran Bingham Dec. 7, 2023, 5:28 p.m. UTC | #2 
Quoting Laurent Pinchart via libcamera-devel (2023-12-05 14:45:44)
> lc-compliance requires gtest. When not available on the system, we
> install it using a meson wrap, but it is still better to install the
> system package. Add it as a dependency in README.rst.
> 


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index 4cb996375a9a..ac89d376ad18 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -97,7 +97,7 @@ for android: [optional]
>          libexif-dev libjpeg-dev
>  
>  for lc-compliance: [optional]
> -        libevent-dev
> +        libevent-dev libgtest-dev
>  
>  for abi-compat.sh: [optional]
>          abi-compliance-checker
> 
> base-commit: 9d08a134c4195ad98dd09c5a9e2558a5765762f7
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index 4cb996375a9a..ac89d376ad18 100644
--- a/README.rst
+++ b/README.rst
@@ -97,7 +97,7 @@  for android: [optional]
         libexif-dev libjpeg-dev
 
 for lc-compliance: [optional]
-        libevent-dev
+        libevent-dev libgtest-dev
 
 for abi-compat.sh: [optional]
         abi-compliance-checker