[libcamera-devel] README.rst: Drop indirect dependencies on Qt5 packages
diff mbox series

Message ID 20231204071511.25676-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 197009f06eeb50a6542c31f5df8c003b8c49144b
Headers show
Series
  • [libcamera-devel] README.rst: Drop indirect dependencies on Qt5 packages
Related show

Commit Message

Laurent Pinchart Dec. 4, 2023, 7:15 a.m. UTC 
The libqt5core5a, libqt5gui5 and libqt5widgets packages are dependencies
of the qtbase5-dev package. There's no need to list them explicitly.

While at it, sort the qcam dependencies alphabetically.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c

Comments

Umang Jain Dec. 4, 2023, 7:21 a.m. UTC | #1 
Hi Laurent,

Thanks for the patch

On 12/4/23 12:45 PM, Laurent Pinchart via libcamera-devel wrote:
> The libqt5core5a, libqt5gui5 and libqt5widgets packages are dependencies
> of the qtbase5-dev package. There's no need to list them explicitly.
>
> While at it, sort the qcam dependencies alphabetically.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

LGTM,

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   README.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.rst b/README.rst
> index e2938af7731d..4cb996375a9a 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -88,7 +88,7 @@ for cam: [optional]
>           - libsdl2-dev: Enables the SDL sink
>   
>   for qcam: [optional]
> -        qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
> +        libtiff-dev qtbase5-dev qttools5-dev-tools
>   
>   for tracing with lttng: [optional]
>           liblttng-ust-dev python3-jinja2 lttng-tools
>
> base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c
Kieran Bingham Dec. 4, 2023, 1:22 p.m. UTC | #2 
Quoting Laurent Pinchart via libcamera-devel (2023-12-04 07:15:11)
> The libqt5core5a, libqt5gui5 and libqt5widgets packages are dependencies
> of the qtbase5-dev package. There's no need to list them explicitly.

Oh that's helpful and simpler.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> While at it, sort the qcam dependencies alphabetically.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index e2938af7731d..4cb996375a9a 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -88,7 +88,7 @@ for cam: [optional]
>          - libsdl2-dev: Enables the SDL sink
>  
>  for qcam: [optional]
> -        qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
> +        libtiff-dev qtbase5-dev qttools5-dev-tools
>  
>  for tracing with lttng: [optional]
>          liblttng-ust-dev python3-jinja2 lttng-tools
> 
> base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index e2938af7731d..4cb996375a9a 100644
--- a/README.rst
+++ b/README.rst
@@ -88,7 +88,7 @@  for cam: [optional]
         - libsdl2-dev: Enables the SDL sink
 
 for qcam: [optional]
-        qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
+        libtiff-dev qtbase5-dev qttools5-dev-tools
 
 for tracing with lttng: [optional]
         liblttng-ust-dev python3-jinja2 lttng-tools