[libcamera-devel] README.rst: Document dependencies for the Python bindings
diff mbox series

Message ID 20231202235707.15433-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 9d08a134c4195ad98dd09c5a9e2558a5765762f7
Headers show
Series
  • [libcamera-devel] README.rst: Document dependencies for the Python bindings
Related show

Commit Message

Laurent Pinchart Dec. 2, 2023, 11:57 p.m. UTC 
The Python bindings require the libpython3-dev and pybind11-dev
packages. Document it along the other dependencies in README.rst.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 README.rst | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c

Comments

Jacopo Mondi Dec. 3, 2023, 5:02 p.m. UTC | #1 
Hi Laurent

On Sun, Dec 03, 2023 at 01:57:07AM +0200, Laurent Pinchart via libcamera-devel wrote:
> The Python bindings require the libpython3-dev and pybind11-dev
> packages. Document it along the other dependencies in README.rst.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  README.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/README.rst b/README.rst
> index a8b91a26983a..e2938af7731d 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -75,6 +75,9 @@ for documentation: [optional]
>  for gstreamer: [optional]
>          libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>
> +for Python bindings: [optional]
> +        libpython3-dev pybind11-dev
> +
>  for cam: [optional]
>          libevent-dev is required to support cam, however the following
>          optional dependencies bring more functionality to the cam test
>
> base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c
> --
> Regards,
>
> Laurent Pinchart
>
Kieran Bingham Dec. 4, 2023, 4:22 p.m. UTC | #2 
Quoting Laurent Pinchart via libcamera-devel (2023-12-02 23:57:07)
> The Python bindings require the libpython3-dev and pybind11-dev
> packages. Document it along the other dependencies in README.rst.
> 

I think I have a patch like this somewhere that I must have never sent.

Anyway,


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  README.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index a8b91a26983a..e2938af7731d 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -75,6 +75,9 @@ for documentation: [optional]
>  for gstreamer: [optional]
>          libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>  
> +for Python bindings: [optional]
> +        libpython3-dev pybind11-dev
> +
>  for cam: [optional]
>          libevent-dev is required to support cam, however the following
>          optional dependencies bring more functionality to the cam test
> 
> base-commit: 8e215127c195b61a7cc787103b129a3af8e5ad2c
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index a8b91a26983a..e2938af7731d 100644
--- a/README.rst
+++ b/README.rst
@@ -75,6 +75,9 @@  for documentation: [optional]
 for gstreamer: [optional]
         libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
 
+for Python bindings: [optional]
+        libpython3-dev pybind11-dev
+
 for cam: [optional]
         libevent-dev is required to support cam, however the following
         optional dependencies bring more functionality to the cam test