| Message ID | 20231023082216.763287-1-dan.scally@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | b5f5a89bc34c601d9b59e160af9db557e1443904 |
| Headers | show |
| Series |
|
| Related | show |
Hi Dan, Thank you for the patch. On Mon, Oct 23, 2023 at 09:22:16AM +0100, Daniel Scally via libcamera-devel wrote: > Qt supports RGB565 natively; add support for the format by mapping > the libcamera format to Qt's representation of it. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/apps/qcam/viewfinder_qt.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp > index 597ccffc..62ed5e7c 100644 > --- a/src/apps/qcam/viewfinder_qt.cpp > +++ b/src/apps/qcam/viewfinder_qt.cpp > @@ -36,6 +36,7 @@ static const QMap<libcamera::PixelFormat, QImage::Format> nativeFormats > { libcamera::formats::RGB888, QImage::Format_BGR888 }, > #endif > { libcamera::formats::BGR888, QImage::Format_RGB888 }, > + { libcamera::formats::RGB565, QImage::Format_RGB16 }, > }; > > ViewFinderQt::ViewFinderQt(QWidget *parent)
Quoting Daniel Scally via libcamera-devel (2023-10-23 09:22:16) > Qt supports RGB565 natively; add support for the format by mapping > the libcamera format to Qt's representation of it. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > src/apps/qcam/viewfinder_qt.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp > index 597ccffc..62ed5e7c 100644 > --- a/src/apps/qcam/viewfinder_qt.cpp > +++ b/src/apps/qcam/viewfinder_qt.cpp > @@ -36,6 +36,7 @@ static const QMap<libcamera::PixelFormat, QImage::Format> nativeFormats > { libcamera::formats::RGB888, QImage::Format_BGR888 }, > #endif > { libcamera::formats::BGR888, QImage::Format_RGB888 }, > + { libcamera::formats::RGB565, QImage::Format_RGB16 }, > }; > > ViewFinderQt::ViewFinderQt(QWidget *parent) > -- > 2.34.1 >
diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp index 597ccffc..62ed5e7c 100644 --- a/src/apps/qcam/viewfinder_qt.cpp +++ b/src/apps/qcam/viewfinder_qt.cpp @@ -36,6 +36,7 @@ static const QMap<libcamera::PixelFormat, QImage::Format> nativeFormats { libcamera::formats::RGB888, QImage::Format_BGR888 }, #endif { libcamera::formats::BGR888, QImage::Format_RGB888 }, + { libcamera::formats::RGB565, QImage::Format_RGB16 }, }; ViewFinderQt::ViewFinderQt(QWidget *parent)
Qt supports RGB565 natively; add support for the format by mapping the libcamera format to Qt's representation of it. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- src/apps/qcam/viewfinder_qt.cpp | 1 + 1 file changed, 1 insertion(+)