| Message ID | 20230925110105.13783-1-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | 870943f80ab42764da532d185f6be44084611242 |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, Thank you for the patch. On Mon, Sep 25, 2023 at 12:01:05PM +0100, Naushir Patuck via libcamera-devel wrote: > This format was defined with the V4L2_PIX_FMT_YUV444M fourcc instead of > the correct V4L2_PIX_FMT_YVU444M fourcc. > > Fixes: 3b9fe4ae996b ("libcamera: formats: Add YUV444 and YVU444 pixel formats") > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Oops. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/v4l2_pixelformat.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp > index a7ae69bb317d..5551c62eb39b 100644 > --- a/src/libcamera/v4l2_pixelformat.cpp > +++ b/src/libcamera/v4l2_pixelformat.cpp > @@ -123,7 +123,7 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{ > { formats::YVU422, "Planar YVU 4:2:2 (N-C)" } }, > { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M), > { formats::YUV444, "Planar YUV 4:4:4 (N-C)" } }, > - { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M), > + { V4L2PixelFormat(V4L2_PIX_FMT_YVU444M), > { formats::YVU444, "Planar YVU 4:4:4 (N-C)" } }, > > /* Greyscale formats. */
Quoting Laurent Pinchart via libcamera-devel (2023-09-25 13:16:44) > Hi Naush, > > Thank you for the patch. > > On Mon, Sep 25, 2023 at 12:01:05PM +0100, Naushir Patuck via libcamera-devel wrote: > > This format was defined with the V4L2_PIX_FMT_YUV444M fourcc instead of > > the correct V4L2_PIX_FMT_YVU444M fourcc. > > > > Fixes: 3b9fe4ae996b ("libcamera: formats: Add YUV444 and YVU444 pixel formats") > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > Oops. Yikes indeed. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > src/libcamera/v4l2_pixelformat.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp > > index a7ae69bb317d..5551c62eb39b 100644 > > --- a/src/libcamera/v4l2_pixelformat.cpp > > +++ b/src/libcamera/v4l2_pixelformat.cpp > > @@ -123,7 +123,7 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{ > > { formats::YVU422, "Planar YVU 4:2:2 (N-C)" } }, > > { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M), > > { formats::YUV444, "Planar YUV 4:4:4 (N-C)" } }, > > - { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M), > > + { V4L2PixelFormat(V4L2_PIX_FMT_YVU444M), > > { formats::YVU444, "Planar YVU 4:4:4 (N-C)" } }, > > > > /* Greyscale formats. */ > > -- > Regards, > > Laurent Pinchart
diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp index a7ae69bb317d..5551c62eb39b 100644 --- a/src/libcamera/v4l2_pixelformat.cpp +++ b/src/libcamera/v4l2_pixelformat.cpp @@ -123,7 +123,7 @@ const std::map<V4L2PixelFormat, V4L2PixelFormat::Info> vpf2pf{ { formats::YVU422, "Planar YVU 4:2:2 (N-C)" } }, { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M), { formats::YUV444, "Planar YUV 4:4:4 (N-C)" } }, - { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M), + { V4L2PixelFormat(V4L2_PIX_FMT_YVU444M), { formats::YVU444, "Planar YVU 4:4:4 (N-C)" } }, /* Greyscale formats. */
This format was defined with the V4L2_PIX_FMT_YUV444M fourcc instead of the correct V4L2_PIX_FMT_YVU444M fourcc. Fixes: 3b9fe4ae996b ("libcamera: formats: Add YUV444 and YVU444 pixel formats") Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/libcamera/v4l2_pixelformat.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)