[libcamera-devel,v2,10/14] libcamera: ipa: meson: Allow access to internal libcamera headers

1898 diff mbox series

Allow IPA implementations to use internal libcamera headers so they can
utilize helpers not exposed to applications.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/ipa/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Niklas,

Thank you for the patch.

On Fri, Aug 30, 2019 at 01:26:49AM +0200, Niklas Söderlund wrote:
> Allow IPA implementations to use internal libcamera headers so they can
> utilize helpers not exposed to applications.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

For open-source IPAs that are shipped with libcamera this is fine, but
third-party IPAs, open-source or closed-source, won't have access to
internal headers.

For the open-source IPAs this isn't a blocker, but should still be
addressed sooner than later. For the closed-source IPAs, I notice you
include v4l2_controls.h in ipa_interface.h, and that's a problem as it
requires linking against libcamera. I would like to discuss how to solve
this issue. In the meantime,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/meson.build b/src/ipa/meson.build
> index 2b9863bce3eabe80..dca7a9461385b68d 100644
> --- a/src/ipa/meson.build
> +++ b/src/ipa/meson.build
> @@ -9,7 +9,7 @@ foreach t : ipa_dummy_sources
>      ipa = shared_module(t[0],
>                          t[1],
>                          name_prefix : '',
> -                        include_directories : libcamera_includes,
> +                        include_directories : includes,
>                          install : true,
>                          install_dir : ipa_install_dir)
>  endforeach