| Message ID | 20230706181447.2698499-1-j-luthra@ti.com |
|---|---|
| State | Accepted |
| Commit | 954ba8a803c078784dfaa6674e687847f49a1dfb |
| Headers | show |
| Series |
|
| Related | show |
Hi Jai, Thank you for the patch. On Thu, Jul 06, 2023 at 11:44:47PM +0530, Jai Luthra wrote: > New TI SoCs from J7 and AM62 family have a camera pipeline that receives > data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing "shim" > IP routes this incoming stream of data to the DMA subsystem, to finally > store the frame data in memory. > > The driver for this is not merged in mainline yet, but v7 was posted [1] > on linux-media list a few months ago. > > With some minor fixes, the work-in-progress v8 series [2] works with the > simple pipeline handler, so we enable support for this device. > > Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] > Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2] > Signed-off-by: Jai Luthra <j-luthra@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > I am planning to post the v8 series for review upstream in the coming few > weeks. > > Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt > > src/libcamera/pipeline/simple/simple.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 7495587c..05ba76bc 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -192,6 +192,7 @@ namespace { > static const SimplePipelineInfo supportedDevices[] = { > { "dcmipp", {} }, > { "imx7-csi", { { "pxp", 1 } } }, > + { "j721e-csi2rx", {} }, > { "mxc-isi", {} }, > { "qcom-camss", {} }, > { "sun6i-csi", {} },
Nice Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> On Thu, Jul 06, 2023 at 11:44:47PM +0530, Jai Luthra via libcamera-devel wrote: > New TI SoCs from J7 and AM62 family have a camera pipeline that receives > data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing "shim" > IP routes this incoming stream of data to the DMA subsystem, to finally > store the frame data in memory. > > The driver for this is not merged in mainline yet, but v7 was posted [1] > on linux-media list a few months ago. > > With some minor fixes, the work-in-progress v8 series [2] works with the > simple pipeline handler, so we enable support for this device. > > Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] > Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2] > Signed-off-by: Jai Luthra <j-luthra@ti.com> > --- > I am planning to post the v8 series for review upstream in the coming few > weeks. > > Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt > > src/libcamera/pipeline/simple/simple.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 7495587c..05ba76bc 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -192,6 +192,7 @@ namespace { > static const SimplePipelineInfo supportedDevices[] = { > { "dcmipp", {} }, > { "imx7-csi", { { "pxp", 1 } } }, > + { "j721e-csi2rx", {} }, > { "mxc-isi", {} }, > { "qcom-camss", {} }, > { "sun6i-csi", {} }, > -- > 2.41.0 >
Hi Jai, Thank you for posting this. On jeu., juil. 06, 2023 at 23:44, Jai Luthra via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote: > New TI SoCs from J7 and AM62 family have a camera pipeline that receives > data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing "shim" > IP routes this incoming stream of data to the DMA subsystem, to finally > store the frame data in memory. > > The driver for this is not merged in mainline yet, but v7 was posted [1] > on linux-media list a few months ago. > > With some minor fixes, the work-in-progress v8 series [2] works with the > simple pipeline handler, so we enable support for this device. > > Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] > Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2] > Signed-off-by: Jai Luthra <j-luthra@ti.com> I've been running a similar change on my own fork for AM62x SK EVM with Android I confirm this works fine. Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on am62 sk evm > --- > I am planning to post the v8 series for review upstream in the coming few > weeks. > > Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt > > src/libcamera/pipeline/simple/simple.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 7495587c..05ba76bc 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -192,6 +192,7 @@ namespace { > static const SimplePipelineInfo supportedDevices[] = { > { "dcmipp", {} }, > { "imx7-csi", { { "pxp", 1 } } }, > + { "j721e-csi2rx", {} }, > { "mxc-isi", {} }, > { "qcom-camss", {} }, > { "sun6i-csi", {} }, > -- > 2.41.0
Hi Mattijs, Quoting Mattijs Korpershoek via libcamera-devel (2023-07-10 16:33:09) > Hi Jai, > > Thank you for posting this. > > On jeu., juil. 06, 2023 at 23:44, Jai Luthra via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote: > > > New TI SoCs from J7 and AM62 family have a camera pipeline that receives > > data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing "shim" > > IP routes this incoming stream of data to the DMA subsystem, to finally > > store the frame data in memory. > > > > The driver for this is not merged in mainline yet, but v7 was posted [1] > > on linux-media list a few months ago. > > > > With some minor fixes, the work-in-progress v8 series [2] works with the > > simple pipeline handler, so we enable support for this device. > > > > Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] > > Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2] > > Signed-off-by: Jai Luthra <j-luthra@ti.com> > > I've been running a similar change on my own fork for AM62x SK EVM with > Android I confirm this works fine. > > Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on am62 sk evm Thank you for the Tested-by: tag - that's always very welcome. I can't add it here though on this occasion I'm afraid as this patch has already been merged. https://git.libcamera.org/libcamera/libcamera.git/commit/?id=954ba8a803c078784dfaa6674e687847f49a1dfb Regards -- Kieran > > > --- > > I am planning to post the v8 series for review upstream in the coming few > > weeks. > > > > Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt > > > > src/libcamera/pipeline/simple/simple.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > > index 7495587c..05ba76bc 100644 > > --- a/src/libcamera/pipeline/simple/simple.cpp > > +++ b/src/libcamera/pipeline/simple/simple.cpp > > @@ -192,6 +192,7 @@ namespace { > > static const SimplePipelineInfo supportedDevices[] = { > > { "dcmipp", {} }, > > { "imx7-csi", { { "pxp", 1 } } }, > > + { "j721e-csi2rx", {} }, > > { "mxc-isi", {} }, > > { "qcom-camss", {} }, > > { "sun6i-csi", {} }, > > -- > > 2.41.0
Hi Kieran, On lun., juil. 10, 2023 at 16:39, Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > Hi Mattijs, > > Quoting Mattijs Korpershoek via libcamera-devel (2023-07-10 16:33:09) >> Hi Jai, >> >> Thank you for posting this. >> >> On jeu., juil. 06, 2023 at 23:44, Jai Luthra via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote: >> >> > New TI SoCs from J7 and AM62 family have a camera pipeline that receives >> > data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing "shim" >> > IP routes this incoming stream of data to the DMA subsystem, to finally >> > store the frame data in memory. >> > >> > The driver for this is not merged in mainline yet, but v7 was posted [1] >> > on linux-media list a few months ago. >> > >> > With some minor fixes, the work-in-progress v8 series [2] works with the >> > simple pipeline handler, so we enable support for this device. >> > >> > Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] >> > Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2] >> > Signed-off-by: Jai Luthra <j-luthra@ti.com> >> >> I've been running a similar change on my own fork for AM62x SK EVM with >> Android I confirm this works fine. >> >> Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on am62 sk evm > > Thank you for the Tested-by: tag - that's always very welcome. > > I can't add it here though on this occasion I'm afraid as this patch has > already been merged. I did not check that it was already merged, sorry for the noise. I understand that it can't be added, no worries. > > https://git.libcamera.org/libcamera/libcamera.git/commit/?id=954ba8a803c078784dfaa6674e687847f49a1dfb > > Regards > -- > Kieran > > >> >> > --- >> > I am planning to post the v8 series for review upstream in the coming few >> > weeks. >> > >> > Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt >> > >> > src/libcamera/pipeline/simple/simple.cpp | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp >> > index 7495587c..05ba76bc 100644 >> > --- a/src/libcamera/pipeline/simple/simple.cpp >> > +++ b/src/libcamera/pipeline/simple/simple.cpp >> > @@ -192,6 +192,7 @@ namespace { >> > static const SimplePipelineInfo supportedDevices[] = { >> > { "dcmipp", {} }, >> > { "imx7-csi", { { "pxp", 1 } } }, >> > + { "j721e-csi2rx", {} }, >> > { "mxc-isi", {} }, >> > { "qcom-camss", {} }, >> > { "sun6i-csi", {} }, >> > -- >> > 2.41.0
diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 7495587c..05ba76bc 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -192,6 +192,7 @@ namespace { static const SimplePipelineInfo supportedDevices[] = { { "dcmipp", {} }, { "imx7-csi", { { "pxp", 1 } } }, + { "j721e-csi2rx", {} }, { "mxc-isi", {} }, { "qcom-camss", {} }, { "sun6i-csi", {} },
New TI SoCs from J7 and AM62 family have a camera pipeline that receives data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing "shim" IP routes this incoming stream of data to the DMA subsystem, to finally store the frame data in memory. The driver for this is not merged in mainline yet, but v7 was posted [1] on linux-media list a few months ago. With some minor fixes, the work-in-progress v8 series [2] works with the simple pipeline handler, so we enable support for this device. Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2] Signed-off-by: Jai Luthra <j-luthra@ti.com> --- I am planning to post the v8 series for review upstream in the coming few weeks. Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt src/libcamera/pipeline/simple/simple.cpp | 1 + 1 file changed, 1 insertion(+)