| Message ID | 20230704190849.3650613-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | fae9c8f0f20e6fafe23e10b133cace9dc72e8c5a |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Thank you for the patch. On Tue, Jul 04, 2023 at 08:08:49PM +0100, Kieran Bingham via libcamera-devel wrote: > The libcamera thread annotations are for internal use only and are > not part of any public api. Mark the header accordingly by including the s/api/API/ > private.h header guard. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/libcamera/base/thread_annotations.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/libcamera/base/thread_annotations.h b/include/libcamera/base/thread_annotations.h > index e81929f674d7..25b3c7b6cf92 100644 > --- a/include/libcamera/base/thread_annotations.h > +++ b/include/libcamera/base/thread_annotations.h > @@ -7,6 +7,8 @@ > > #pragma once > > +#include <libcamera/base/private.h> > + > /* > * Enable thread safety attributes only with clang. > * The attributes can be safely erased when compiling with other compilers.
Hi Kieran, On 7/4/23 9:08 PM, Kieran Bingham via libcamera-devel wrote: > The libcamera thread annotations are for internal use only and are > not part of any public api. Mark the header accordingly by including the > private.h header guard. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > include/libcamera/base/thread_annotations.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/libcamera/base/thread_annotations.h b/include/libcamera/base/thread_annotations.h > index e81929f674d7..25b3c7b6cf92 100644 > --- a/include/libcamera/base/thread_annotations.h > +++ b/include/libcamera/base/thread_annotations.h > @@ -7,6 +7,8 @@ > > #pragma once > > +#include <libcamera/base/private.h> > + > /* > * Enable thread safety attributes only with clang. > * The attributes can be safely erased when compiling with other compilers.
diff --git a/include/libcamera/base/thread_annotations.h b/include/libcamera/base/thread_annotations.h index e81929f674d7..25b3c7b6cf92 100644 --- a/include/libcamera/base/thread_annotations.h +++ b/include/libcamera/base/thread_annotations.h @@ -7,6 +7,8 @@ #pragma once +#include <libcamera/base/private.h> + /* * Enable thread safety attributes only with clang. * The attributes can be safely erased when compiling with other compilers.
The libcamera thread annotations are for internal use only and are not part of any public api. Mark the header accordingly by including the private.h header guard. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- include/libcamera/base/thread_annotations.h | 2 ++ 1 file changed, 2 insertions(+)