[libcamera-devel] libipa: camera_sensor_helper: restore alphabetical order
diff mbox series

Message ID 20230606-alphabetical-order-v1-1-3c9c12a1a332@skidata.com
State Accepted
Commit 0a37c203da58b3c23c011d8233c16c6063e3cb86
Headers show
Series
  • [libcamera-devel] libipa: camera_sensor_helper: restore alphabetical order
Related show

Commit Message

Benjamin Bara June 6, 2023, 2:18 p.m. UTC 
From: Benjamin Bara <benjamin.bara@skidata.com>

Fixes: 7d5b38e2ef41 ("libipa: camera_sensor_helper: Add IMX327 helper")
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>
---
Unfortunately missed to keep the alphabetical order as mentioned by
Laurent.
---
 src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)


---
base-commit: a0271e72a86da5796891795565f43f20f7024a8d
change-id: 20230606-alphabetical-order-ea13b8e95f1e

Best regards,

Comments

Kieran Bingham June 6, 2023, 2:22 p.m. UTC | #1 
Hi Benjamin,

Quoting Benjamin Bara via libcamera-devel (2023-06-06 15:18:05)
> From: Benjamin Bara <benjamin.bara@skidata.com>
> 

I'd still add a commit message here. We can add while applying if you're
happy:

The addition of the CameraSensorHelperImx327 class was not correctly
inserted in alphabetical sort order.

Move it to the correct location.

> Fixes: 7d5b38e2ef41 ("libipa: camera_sensor_helper: Add IMX327 helper")
> Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
> Unfortunately missed to keep the alphabetical order as mentioned by
> Laurent.
> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index 2eebd7ab..f0ecc383 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -428,11 +428,6 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290)
>  
> -class CameraSensorHelperImx327 : public CameraSensorHelperImx290
> -{
> -};
> -REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327)
> -
>  class CameraSensorHelperImx296 : public CameraSensorHelper
>  {
>  public:
> @@ -444,6 +439,11 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296)
>  
> +class CameraSensorHelperImx327 : public CameraSensorHelperImx290
> +{
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327)
> +
>  class CameraSensorHelperImx477 : public CameraSensorHelper
>  {
>  public:
> 
> ---
> base-commit: a0271e72a86da5796891795565f43f20f7024a8d
> change-id: 20230606-alphabetical-order-ea13b8e95f1e
> 
> Best regards,
> -- 
> Benjamin Bara <benjamin.bara@skidata.com>
>

Patch
diff mbox series 

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index 2eebd7ab..f0ecc383 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -428,11 +428,6 @@  public:
 };
 REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290)
 
-class CameraSensorHelperImx327 : public CameraSensorHelperImx290
-{
-};
-REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327)
-
 class CameraSensorHelperImx296 : public CameraSensorHelper
 {
 public:
@@ -444,6 +439,11 @@  public:
 };
 REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296)
 
+class CameraSensorHelperImx327 : public CameraSensorHelperImx290
+{
+};
+REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327)
+
 class CameraSensorHelperImx477 : public CameraSensorHelper
 {
 public: