| Message ID | 20230603075615.20663-2-tomi.valkeinen@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Tomi, Thank you for the patch. On Sat, Jun 03, 2023 at 10:56:03AM +0300, Tomi Valkeinen wrote: > As we no longer have pybind11 as a subproject, drop it from the > gitignore. This should have Fixes: ad4719c10c6a ("py: Move to mainline pybind11 version") > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> While at it, you should drop subprojects/packagefiles/pybind11/meson.build. I'll do so and update the commit message to subprojects: Drop leftovers of pybind11 The pybind11 subproject was removed in commit ad4719c10c6a ("py: Move to mainline pybind11 version"), but two traces remained, one in .gitignore and a second one as a meson.build for pybind11. Remove them. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > subprojects/.gitignore | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore > index ebe59479..04b6271f 100644 > --- a/subprojects/.gitignore > +++ b/subprojects/.gitignore > @@ -4,4 +4,3 @@ > /libyaml > /libyuv > /packagecache > -/pybind11-*
On 04/06/2023 11:47, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Sat, Jun 03, 2023 at 10:56:03AM +0300, Tomi Valkeinen wrote: >> As we no longer have pybind11 as a subproject, drop it from the >> gitignore. > > This should have > > Fixes: ad4719c10c6a ("py: Move to mainline pybind11 version") > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > > While at it, you should drop > subprojects/packagefiles/pybind11/meson.build. I'll do so and update the > commit message to Ah. So we keep finding these leftovers. I wonder if this one is the last =). > subprojects: Drop leftovers of pybind11 > > The pybind11 subproject was removed in commit ad4719c10c6a ("py: Move to > mainline pybind11 version"), but two traces remained, one in .gitignore > and a second one as a meson.build for pybind11. Remove them. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Looks fine to me. Tomi
diff --git a/subprojects/.gitignore b/subprojects/.gitignore index ebe59479..04b6271f 100644 --- a/subprojects/.gitignore +++ b/subprojects/.gitignore @@ -4,4 +4,3 @@ /libyaml /libyuv /packagecache -/pybind11-*
As we no longer have pybind11 as a subproject, drop it from the gitignore. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> --- subprojects/.gitignore | 1 - 1 file changed, 1 deletion(-)