[libcamera-devel,v2] libcamera: controls: Define a default lens position behaviour
diff mbox series

Message ID 20230602060947.16309-1-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel,v2] libcamera: controls: Define a default lens position behaviour
Related show

Commit Message

Laurent Pinchart June 2, 2023, 6:09 a.m. UTC 
From: Naushir Patuck <naush@raspberrypi.com>

Update the AfMode control description to explicitly define a
startup/default behaviour.

On startup, the camera will move the lens to the position given by the
default value of the LensPosition control if operating in manual focus
mode. Typically this would be the hyperfocal position of the lens.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/libcamera/control_ids.yaml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Naushir Patuck June 2, 2023, 8:36 a.m. UTC | #1 
Hi Laurent,

Seems clearer, I'm happy with this change!

Regards,
Naush

On Fri, 2 Jun 2023 at 07:09, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> From: Naushir Patuck <naush@raspberrypi.com>
>
> Update the AfMode control description to explicitly define a
> startup/default behaviour.
>
> On startup, the camera will move the lens to the position given by the
> default value of the LensPosition control if operating in manual focus
> mode. Typically this would be the hyperfocal position of the lens.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> ---
>  src/libcamera/control_ids.yaml | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index 76d41f5f2a5a..985f792a53c1 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -408,7 +408,15 @@ controls:
>              LensPosition control.
>
>              In this mode the AfState will always report AfStateIdle.
> -        - name: AfModeAuto
> +
> +            If the camera is started is AfModeManual, it will move the focus
> +            lens to the position specified by the LensPosition control.
> +
> +            This mode is the recommended default value for the AfMode control.
> +            External cameras (as reported by the Location property set to
> +            CameraLocationExternal) may use a different default value.
> +
> +         name: AfModeAuto
>            value: 1
>            description: |
>              The AF algorithm is in auto mode. This means that the algorithm
> --
> Regards,
>
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 76d41f5f2a5a..985f792a53c1 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -408,7 +408,15 @@  controls:
             LensPosition control.
 
             In this mode the AfState will always report AfStateIdle.
-        - name: AfModeAuto
+
+            If the camera is started is AfModeManual, it will move the focus
+            lens to the position specified by the LensPosition control.
+
+            This mode is the recommended default value for the AfMode control.
+            External cameras (as reported by the Location property set to
+            CameraLocationExternal) may use a different default value.
+
+         name: AfModeAuto
           value: 1
           description: |
             The AF algorithm is in auto mode. This means that the algorithm