[libcamera-devel] ipa: raspberrypi: agc: Add "shadows" constraint mode
diff mbox series

Message ID 20230411094757.29143-1-david.plowman@raspberrypi.com
State Accepted
Commit 98fc381c68a372b78260b2940411a64ea9e5011c
Headers show
Series
  • [libcamera-devel] ipa: raspberrypi: agc: Add "shadows" constraint mode
Related show

Commit Message

David Plowman April 11, 2023, 9:47 a.m. UTC 
The "shadows" constraint mode actually exists in a number of tuning
files, but had been omitted from the list of supported modes.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/ipa/raspberrypi/raspberrypi.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Kieran Bingham April 11, 2023, 2:38 p.m. UTC | #1 
Quoting David Plowman via libcamera-devel (2023-04-11 10:47:57)
> The "shadows" constraint mode actually exists in a number of tuning
> files, but had been omitted from the list of supported modes.
> 
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 9f3f3ac3..9c29fa9a 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -778,6 +778,7 @@ static const std::map<int32_t, std::string> MeteringModeTable = {
>  static const std::map<int32_t, std::string> ConstraintModeTable = {
>         { controls::ConstraintNormal, "normal" },
>         { controls::ConstraintHighlight, "highlight" },
> +       { controls::ConstraintShadows, "shadows" },
>         { controls::ConstraintCustom, "custom" },
>  };
>  
> -- 
> 2.30.2
>
Laurent Pinchart April 12, 2023, 8:56 a.m. UTC | #2 
Hi David,

Thank you for the patch.

On Tue, Apr 11, 2023 at 10:47:57AM +0100, David Plowman via libcamera-devel wrote:
> The "shadows" constraint mode actually exists in a number of tuning
> files, but had been omitted from the list of supported modes.
> 
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 9f3f3ac3..9c29fa9a 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -778,6 +778,7 @@ static const std::map<int32_t, std::string> MeteringModeTable = {
>  static const std::map<int32_t, std::string> ConstraintModeTable = {
>  	{ controls::ConstraintNormal, "normal" },
>  	{ controls::ConstraintHighlight, "highlight" },
> +	{ controls::ConstraintShadows, "shadows" },
>  	{ controls::ConstraintCustom, "custom" },
>  };
>

Patch
diff mbox series 

diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
index 9f3f3ac3..9c29fa9a 100644
--- a/src/ipa/raspberrypi/raspberrypi.cpp
+++ b/src/ipa/raspberrypi/raspberrypi.cpp
@@ -778,6 +778,7 @@  static const std::map<int32_t, std::string> MeteringModeTable = {
 static const std::map<int32_t, std::string> ConstraintModeTable = {
 	{ controls::ConstraintNormal, "normal" },
 	{ controls::ConstraintHighlight, "highlight" },
+	{ controls::ConstraintShadows, "shadows" },
 	{ controls::ConstraintCustom, "custom" },
 };