[libcamera-devel,GIT,PULL] Raspberry Pi: Senor limits
mbox series

Message ID CAEmqJPpS6zek8gUaEojhafenKgV1uaBFYQiznviQ5wNgTe3dCQ@mail.gmail.com
State Superseded
Headers show
Series
  • [libcamera-devel,GIT,PULL] Raspberry Pi: Senor limits
Related show

Pull-request

https://github.com/naushir/libcamera.git

Message

Naushir Patuck March 28, 2023, 11:52 a.m. UTC 
The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:

  libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after
exec(3) (2023-03-26 11:48:18 +0300)

are available in the Git repository at:

  https://github.com/naushir/libcamera.git

for you to fetch changes up to 798a05610c07ba071b51acdedf35294709a9c23e:

  ipa: raspberrypi: Fix default frame durations calculation
(2023-03-28 12:47:45 +0100)

----------------------------------------------------------------
Naushir Patuck (4):
      ipa: raspberrypi: Add sensor mode limits to CameraMode
      ipa: raspberrypi: Use the new sensor limits fields in CameraMode
      ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC
      ipa: raspberrypi: Fix default frame durations calculation

 src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-
 src/ipa/raspberrypi/controller/rpi/agc.cpp   | 58
++++++++++++++++++++++++++++++++++++++++++++--------------
 src/ipa/raspberrypi/controller/rpi/agc.h     |  5 +++--
 src/ipa/raspberrypi/raspberrypi.cpp          | 57
+++++++++++++++++++++++++++++----------------------------
 4 files changed, 85 insertions(+), 45 deletions(-)

Comments

Kieran Bingham March 28, 2023, noon UTC | #1 
Quoting Naushir Patuck (2023-03-28 12:52:39)
> The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:
> 
>   libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after
> exec(3) (2023-03-26 11:48:18 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/naushir/libcamera.git
> 
> for you to fetch changes up to 798a05610c07ba071b51acdedf35294709a9c23e:

Hi Naush,

FAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o 
g++-9 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/gcc-9/config.h -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp
../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp: In constructor ‘RPiController::Agc::Agc(RPiController::Controller*)’:
../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:226:29: error: class ‘RPiController::Agc’ does not have any field named ‘lastSensitivity_’
  226 |    lastTargetExposure_(0s), lastSensitivity_(0.0),
      |                             ^~~~~~~~~~~~~~~~

Sorry - not a complete fix.

--
Kieran


> 
>   ipa: raspberrypi: Fix default frame durations calculation
> (2023-03-28 12:47:45 +0100)
> 
> ----------------------------------------------------------------
> Naushir Patuck (4):
>       ipa: raspberrypi: Add sensor mode limits to CameraMode
>       ipa: raspberrypi: Use the new sensor limits fields in CameraMode
>       ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC
>       ipa: raspberrypi: Fix default frame durations calculation
> 
>  src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-
>  src/ipa/raspberrypi/controller/rpi/agc.cpp   | 58
> ++++++++++++++++++++++++++++++++++++++++++++--------------
>  src/ipa/raspberrypi/controller/rpi/agc.h     |  5 +++--
>  src/ipa/raspberrypi/raspberrypi.cpp          | 57
> +++++++++++++++++++++++++++++----------------------------
>  4 files changed, 85 insertions(+), 45 deletions(-)
Naushir Patuck March 28, 2023, 12:01 p.m. UTC | #2 
On Tue, 28 Mar 2023 at 13:00, Kieran Bingham
<kieran.bingham@ideasonboard.com> wrote:
>
> Quoting Naushir Patuck (2023-03-28 12:52:39)
> > The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:
> >
> >   libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after
> > exec(3) (2023-03-26 11:48:18 +0300)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/naushir/libcamera.git
> >
> > for you to fetch changes up to 798a05610c07ba071b51acdedf35294709a9c23e:
>
> Hi Naush,
>
> FAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o
> g++-9 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/gcc-9/config.h -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp
> ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp: In constructor ‘RPiController::Agc::Agc(RPiController::Controller*)’:
> ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:226:29: error: class ‘RPiController::Agc’ does not have any field named ‘lastSensitivity_’
>   226 |    lastTargetExposure_(0s), lastSensitivity_(0.0),
>       |                             ^~~~~~~~~~~~~~~~
>
> Sorry - not a complete fix.

And again... :(

>
> --
> Kieran
>
>
> >
> >   ipa: raspberrypi: Fix default frame durations calculation
> > (2023-03-28 12:47:45 +0100)
> >
> > ----------------------------------------------------------------
> > Naushir Patuck (4):
> >       ipa: raspberrypi: Add sensor mode limits to CameraMode
> >       ipa: raspberrypi: Use the new sensor limits fields in CameraMode
> >       ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC
> >       ipa: raspberrypi: Fix default frame durations calculation
> >
> >  src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-
> >  src/ipa/raspberrypi/controller/rpi/agc.cpp   | 58
> > ++++++++++++++++++++++++++++++++++++++++++++--------------
> >  src/ipa/raspberrypi/controller/rpi/agc.h     |  5 +++--
> >  src/ipa/raspberrypi/raspberrypi.cpp          | 57
> > +++++++++++++++++++++++++++++----------------------------
> >  4 files changed, 85 insertions(+), 45 deletions(-)