[libcamera-devel,GIT,PULL] Raspberry Pi: Senor limits
mbox series

Message ID CAEmqJPrssS6rWqzqU1ZXNYqQ_qFPvcV+_mNBh1nbv5=Z5yB+Fg@mail.gmail.com
State Superseded
Headers show
Series
  • [libcamera-devel,GIT,PULL] Raspberry Pi: Senor limits
Related show

Pull-request

https://github.com/naushir/libcamera.git

Message

Naushir Patuck March 28, 2023, 7:41 a.m. UTC 
The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:

  libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after
exec(3) (2023-03-26 11:48:18 +0300)

are available in the Git repository at:

  https://github.com/naushir/libcamera.git

for you to fetch changes up to 4ec84728accfdf4df2250cec153e0aa396758b12:

  ipa: raspberrypi: Fix default frame durations calculation
(2023-03-28 08:38:05 +0100)

----------------------------------------------------------------
Naushir Patuck (4):
      ipa: raspberrypi: Add sensor mode limits to CameraMode
      ipa: raspberrypi: Use the new sensor limits fields in CameraMode
      ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC
      ipa: raspberrypi: Fix default frame durations calculation

 src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-
 src/ipa/raspberrypi/controller/rpi/agc.cpp   | 55
++++++++++++++++++++++++++++++++++++++++++-------------
 src/ipa/raspberrypi/controller/rpi/agc.h     |  4 +++-
 src/ipa/raspberrypi/raspberrypi.cpp          | 57
+++++++++++++++++++++++++++++----------------------------
 4 files changed, 83 insertions(+), 43 deletions(-)

Comments

Kieran Bingham March 28, 2023, 11:30 a.m. UTC | #1 
Hi Naush,

Quoting Naushir Patuck (2023-03-28 08:41:45)
> The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:
> 
>   libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after
> exec(3) (2023-03-26 11:48:18 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/naushir/libcamera.git
> 
> for you to fetch changes up to 4ec84728accfdf4df2250cec153e0aa396758b12:

I hit the following error in the build-matrix I'm afraid:

[8/49] Compiling C++ object src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o
FAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o
clang++-11 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp
In file included from ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:20:
../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.h:129:9: error: private field 'lastSensitivity_' is not used [-Werror,-Wunused-private-field]
        double lastSensitivity_; /* sensitivity of the previous camera mode */
               ^
1 error generated.


> 
>   ipa: raspberrypi: Fix default frame durations calculation
> (2023-03-28 08:38:05 +0100)
> 
> ----------------------------------------------------------------
> Naushir Patuck (4):
>       ipa: raspberrypi: Add sensor mode limits to CameraMode
>       ipa: raspberrypi: Use the new sensor limits fields in CameraMode
>       ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC
>       ipa: raspberrypi: Fix default frame durations calculation
> 
>  src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-
>  src/ipa/raspberrypi/controller/rpi/agc.cpp   | 55
> ++++++++++++++++++++++++++++++++++++++++++-------------
>  src/ipa/raspberrypi/controller/rpi/agc.h     |  4 +++-
>  src/ipa/raspberrypi/raspberrypi.cpp          | 57
> +++++++++++++++++++++++++++++----------------------------
>  4 files changed, 83 insertions(+), 43 deletions(-)
Naushir Patuck March 28, 2023, 11:48 a.m. UTC | #2 
On Tue, 28 Mar 2023 at 12:30, Kieran Bingham
<kieran.bingham@ideasonboard.com> wrote:
>
> Hi Naush,
>
> Quoting Naushir Patuck (2023-03-28 08:41:45)
> > The following changes since commit d942bdc913c5a7f0895bfcb0180db3f279be246e:
> >
> >   libcamera: v4l2_device: openat(2) with O_CLOEXEC to cleanup after
> > exec(3) (2023-03-26 11:48:18 +0300)
> >
> > are available in the Git repository at:
> >
> >   https://github.com/naushir/libcamera.git
> >
> > for you to fetch changes up to 4ec84728accfdf4df2250cec153e0aa396758b12:
>
> I hit the following error in the build-matrix I'm afraid:
>
> [8/49] Compiling C++ object src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o
> FAILED: src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o
> clang++-11 -Isrc/ipa/raspberrypi/ipa_rpi.so.p -Isrc/ipa/raspberrypi -I../../../src/libcamera/src/ipa/raspberrypi -Iinclude -I../../../src/libcamera/include -Isrc/ipa -I../../../src/libcamera/src/ipa -I../../../src/libcamera/src/ipa/raspberrypi/controller -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -MF src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o.d -o src/ipa/raspberrypi/ipa_rpi.so.p/controller_rpi_agc.cpp.o -c ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp
> In file included from ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.cpp:20:
> ../../../src/libcamera/src/ipa/raspberrypi/controller/rpi/agc.h:129:9: error: private field 'lastSensitivity_' is not used [-Werror,-Wunused-private-field]
>         double lastSensitivity_; /* sensitivity of the previous camera mode */

Oops, sorry about that! David did point it out and I forgot to remove the field.

I'll push an update and send another [GIT PULL] request.

Regards,
Naush


>                ^
> 1 error generated.
>
>
> >
> >   ipa: raspberrypi: Fix default frame durations calculation
> > (2023-03-28 08:38:05 +0100)
> >
> > ----------------------------------------------------------------
> > Naushir Patuck (4):
> >       ipa: raspberrypi: Add sensor mode limits to CameraMode
> >       ipa: raspberrypi: Use the new sensor limits fields in CameraMode
> >       ipa: raspberrypi: Ensure shutter speed and gain are clipped in the AGC
> >       ipa: raspberrypi: Fix default frame durations calculation
> >
> >  src/ipa/raspberrypi/controller/camera_mode.h | 10 +++++++++-
> >  src/ipa/raspberrypi/controller/rpi/agc.cpp   | 55
> > ++++++++++++++++++++++++++++++++++++++++++-------------
> >  src/ipa/raspberrypi/controller/rpi/agc.h     |  4 +++-
> >  src/ipa/raspberrypi/raspberrypi.cpp          | 57
> > +++++++++++++++++++++++++++++----------------------------
> >  4 files changed, 83 insertions(+), 43 deletions(-)