[libcamera-devel,02/11] include: drm_fourcc: Add Y10 format
diff mbox series

Message ID 20230318234014.29506-3-dan.scally@ideasonboard.com
State New
Headers show
Series
  • Support OV7251 in IPU3 pipeline and qcam
Related show

Commit Message

Dan Scally March 18, 2023, 11:40 p.m. UTC
Add a FourCC entry for the V4L2_PIX_FMT_Y10 image data format.

Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
---
 include/linux/drm_fourcc.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Laurent Pinchart March 19, 2023, 1:59 p.m. UTC | #1
Hi Dan,

Thank you for the patch.

On Sat, Mar 18, 2023 at 11:40:05PM +0000, Daniel Scally via libcamera-devel wrote:
> Add a FourCC entry for the V4L2_PIX_FMT_Y10 image data format.
> 
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
>  include/linux/drm_fourcc.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h
> index 1496e097..b181a534 100644
> --- a/include/linux/drm_fourcc.h
> +++ b/include/linux/drm_fourcc.h
> @@ -98,6 +98,9 @@ extern "C" {
>  /* Reserve 0 for the invalid format specifier */
>  #define DRM_FORMAT_INVALID	0
>  
> +/* 10 bpp greyscale */
> +#define DRM_FORMAT_Y10		fourcc_code('Y', '1', '0', ' ') /* [15:0] Y-only little endian*/

For historical reasons, greyscale formats are named "R" in DRM. We
already have DRM_FORMAT_R10 support, so you should be all set.

By the way, if you need to add a new DRM format in the future, the patch
should be sent to the kernel first.

>  /* color index */
>  #define DRM_FORMAT_C8		fourcc_code('C', '8', ' ', ' ') /* [7:0] C */
>

Patch
diff mbox series

diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h
index 1496e097..b181a534 100644
--- a/include/linux/drm_fourcc.h
+++ b/include/linux/drm_fourcc.h
@@ -98,6 +98,9 @@  extern "C" {
 /* Reserve 0 for the invalid format specifier */
 #define DRM_FORMAT_INVALID	0
 
+/* 10 bpp greyscale */
+#define DRM_FORMAT_Y10		fourcc_code('Y', '1', '0', ' ') /* [15:0] Y-only little endian*/
+
 /* color index */
 #define DRM_FORMAT_C8		fourcc_code('C', '8', ' ', ' ') /* [7:0] C */