[libcamera-devel] documentation: small fixes

18276 diff mbox series

Out should really be output, and document dependency on pkg-config.
    
Signed-off-by: Pavel Machek <pavel@ucw.cz>

Hi Pavel,

Thank you for the patch.

On Sat, Feb 11, 2023 at 10:59:14PM +0100, Pavel Machek via libcamera-devel wrote:
> Out should really be output, and document dependency on pkg-config.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
> index 1b2d7727..c46d3362 100644
> --- a/Documentation/guides/application-developer.rst
> +++ b/Documentation/guides/application-developer.rst
> @@ -5,7 +5,7 @@ Using libcamera in a C++ application
>  
>  This tutorial shows how to create a C++ application that uses libcamera to
>  interface with a camera on a system, capture frames from it for 3 seconds, and
> -write metadata about the frames to standard out.
> +write metadata about the frames to standard output.

Good fix.

>  
>  Application skeleton
>  --------------------
> diff --git a/README.rst b/README.rst
> index 34b6b49f..f94c0880 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -84,7 +84,7 @@ for gstreamer: [optional]
>          libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>  
>  for cam: [optional]
> -        libevent-dev is required to support cam, however the following
> +        libevent-dev + pkg-config is required to support cam, however the following

pkg-config is documented as required by meson a few lines above:

Meson Build system: [required]
        meson (>= 0.56) ninja-build pkg-config

>          optional dependencies bring more functionality to the cam test
>          tool:
>

Hi!

> Thank you for the patch.

Thanks for review.

> On Sat, Feb 11, 2023 at 10:59:14PM +0100, Pavel Machek via libcamera-devel wrote:
> > Out should really be output, and document dependency on pkg-config.
> >     
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
> > index 1b2d7727..c46d3362 100644
> > --- a/Documentation/guides/application-developer.rst
> > +++ b/Documentation/guides/application-developer.rst
> > @@ -5,7 +5,7 @@ Using libcamera in a C++ application
> >  
> >  This tutorial shows how to create a C++ application that uses libcamera to
> >  interface with a camera on a system, capture frames from it for 3 seconds, and
> > -write metadata about the frames to standard out.
> > +write metadata about the frames to standard output.
> 
> Good fix.

Ok, should I resend just the first hunk, or can you just apply the
first hunk?

Best regards,
								Pavel

On Sun, Feb 12, 2023 at 06:19:19PM +0100, Pavel Machek wrote:
> Hi!
> 
> > Thank you for the patch.
> 
> Thanks for review.
> 
> > On Sat, Feb 11, 2023 at 10:59:14PM +0100, Pavel Machek via libcamera-devel wrote:
> > > Out should really be output, and document dependency on pkg-config.
> > >     
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
> > > index 1b2d7727..c46d3362 100644
> > > --- a/Documentation/guides/application-developer.rst
> > > +++ b/Documentation/guides/application-developer.rst
> > > @@ -5,7 +5,7 @@ Using libcamera in a C++ application
> > >  
> > >  This tutorial shows how to create a C++ application that uses libcamera to
> > >  interface with a camera on a system, capture frames from it for 3 seconds, and
> > > -write metadata about the frames to standard out.
> > > +write metadata about the frames to standard output.
> > 
> > Good fix.
> 
> Ok, should I resend just the first hunk, or can you just apply the
> first hunk?

I've just pushed the first hunk.