| Message ID | 20230208193116.117077-1-umang.jain@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | e72b121d65a6c23a37a12776b777d2eee776dcc6 |
| Headers | show |
| Series |
|
| Related | show |
Hi Umang, Thank you for the patch. On Thu, Feb 09, 2023 at 01:01:16AM +0530, Umang Jain via libcamera-devel wrote: > libcamera uses double quotes "..." for #include directives for > internal headers. > > While at it, move the request internal header include to the right > location. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/libcamera/internal/tracepoints/request.tp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp > index f1e54497..4f367e91 100644 > --- a/include/libcamera/internal/tracepoints/request.tp > +++ b/include/libcamera/internal/tracepoints/request.tp > @@ -5,10 +5,10 @@ > * request.tp - Tracepoints for the request object > */ > > -#include <libcamera/internal/request.h> > - > #include <libcamera/framebuffer.h> > > +#include "libcamera/internal/request.h" > + > TRACEPOINT_EVENT_CLASS( > libcamera, > request,
Quoting Laurent Pinchart via libcamera-devel (2023-02-09 10:24:44) > Hi Umang, > > Thank you for the patch. > > On Thu, Feb 09, 2023 at 01:01:16AM +0530, Umang Jain via libcamera-devel wrote: > > libcamera uses double quotes "..." for #include directives for > > internal headers. > > > > While at it, move the request internal header include to the right > > location. > > > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > include/libcamera/internal/tracepoints/request.tp | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp > > index f1e54497..4f367e91 100644 > > --- a/include/libcamera/internal/tracepoints/request.tp > > +++ b/include/libcamera/internal/tracepoints/request.tp > > @@ -5,10 +5,10 @@ > > * request.tp - Tracepoints for the request object > > */ > > > > -#include <libcamera/internal/request.h> > > - Hrm, the object's own header is supposed to go first in the C++ code, but here we're in the .tp ... so I think it's actually correct to move it. the quotes are definitely a fix. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > #include <libcamera/framebuffer.h> > > > > +#include "libcamera/internal/request.h" > > + > > TRACEPOINT_EVENT_CLASS( > > libcamera, > > request, > > -- > Regards, > > Laurent Pinchart
diff --git a/include/libcamera/internal/tracepoints/request.tp b/include/libcamera/internal/tracepoints/request.tp index f1e54497..4f367e91 100644 --- a/include/libcamera/internal/tracepoints/request.tp +++ b/include/libcamera/internal/tracepoints/request.tp @@ -5,10 +5,10 @@ * request.tp - Tracepoints for the request object */ -#include <libcamera/internal/request.h> - #include <libcamera/framebuffer.h> +#include "libcamera/internal/request.h" + TRACEPOINT_EVENT_CLASS( libcamera, request,
libcamera uses double quotes "..." for #include directives for internal headers. While at it, move the request internal header include to the right location. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- include/libcamera/internal/tracepoints/request.tp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)